Enable idempotency check #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
@ggwpez I think we should be able to merge this now? |
|
Yes was just testing if it goes green 😄 |
|
@brenzi there is an error for decoding the |
|
Yes. I think this can be safely ignored because the storage has been written by the new pallet version already. Only issue that the storage-version wasn't bumped with the proper migration |
bkchr
approved these changes
Feb 29, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
andresilva
approved these changes
Mar 5, 2024
ggwpez
added a commit
that referenced
this pull request
Mar 15, 2024
Trying to enable this check that was disabled because of a non-idempotent migration. cc liamaharon - [x] Does not require a CHANGELOG entry Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added a commit
that referenced
this pull request
Mar 15, 2024
Changes: - Remove all migrations from Polkadot since 1.1.2 was enacted on-chain. Two other commits have been manually back-ported to the release branch and are not shown in the diff: - Enable idempotency check (#164) - [CI] Run on all MRs and on release branch (#173) [x] Does not require a CHANGELOG entry --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to enable this check that was disabled because of a non-idempotent migration.
cc @liamaharon