Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encointer benchmarks #177

Merged
merged 8 commits into from
Feb 13, 2024
Merged

fix encointer benchmarks #177

merged 8 commits into from
Feb 13, 2024

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Feb 7, 2024 •
edited
Loading

closes #155

  • Does not require a CHANGELOG entry

@ggwpez ggwpez mentioned this pull request Feb 7, 2024
Closed
@bkontur
Copy link
Contributor

bkontur commented Feb 12, 2024

@brenzi clippy issue here: #179

@bkontur
Copy link
Contributor

bkontur commented Feb 12, 2024

@brenzi clippy issue here: #179

I have a fix/solution for clippy here: #179 (comment)
As far as I tried locally, that ahash bump does not work, you will have problem with curve25519-dalek and uncompilable bip39-2.0.0 (here I gave up)

@brenzi
Copy link
Contributor Author

brenzi commented Feb 12, 2024

I'll wait for that PR to be merged then?

@bkchr
Copy link
Contributor

bkchr commented Feb 13, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) February 13, 2024 09:36
@bkontur bkontur mentioned this pull request Feb 13, 2024
Closed
@fellowship-merge-bot fellowship-merge-bot bot merged commit b4c3ad6 into polkadot-fellows:main Feb 13, 2024
16 checks passed
@brenzi brenzi mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@skunert skunert skunert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Encointer benchmarks
5 participants
@brenzi @bkontur @bkchr @skunert @ggwpez