-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Runtimes from Polkadot-SDK v1.1.0-rc2
#28
Conversation
v1.1.0-rc2
v1.1.0-rc2
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
c2f4041
to
9c963a4
Compare
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
@ggwpez the weights are all "fresh"? If not, do they need to be regenerated? |
It is best practice to re-generate before each release, so I will open another MR on top of this to update them. |
You can directly push to this pr. I don't see any need to open another pr? |
@liamaharon could you please run all the runtimes using your new try-runtime cli? And best would also be to post instructions on how to reproduce. |
Now it looks a bit more success-y, but the end of the output is as follows:
|
I got the same |
Yeah that is fine. I think @ggwpez is trying to do reproducible builds, without using a reproducible env. |
Yes exactly. It can be ignored, as the final already passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks passed (except getting mismatched runtime hashes which is expected).
* remove executed migration * init storage versions * fix reads * review comments
* Update system-parachain weights Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update system-parachain weights again Just a sanity check for the consistency. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update Relay weights Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
* Add CHANGELOG.md * Bring back .gitattributes
Co-authored-by: André Silva <[email protected]>
If the channel exists, the channel will be closed. The function is only callable by a privileged origin and thus, it should be fine to ignore `c` for now.
I would like to try |
I guess this is fine?
|
Yeah the diff is weight files and some migrations, which looks fine. |
Looks like the review-bot is working good 👍 |
* Update README Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add one more clippy lint from Polkadot-SDK Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update CI dependencies Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Use workspace version 1.1.0 Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Cleanup Cargo.toml and rename glutton-runtime Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add GPL-3.0 license Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Use version 1.0.0 Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update .gitignore and rustfmt Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Delete empty CHANGELOG Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update Cargo.lock Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Set authors to the Fellowship Co-authored-by: Bastian Köcher <[email protected]> * Add the `on-chain-release-build` feature to all runtimes * Rework release action * Test the action * Don't use deprecated command * Use correct name * Try to get it running * Try * Fixes * ... * Try * Now? * Rename * Revert and let it only run on main --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
This marks a clear cut in the development process and implies that from now on, this repository will be used to maintain the Polkadot, Kusama and their System-Parachain runtimes. The cut retroactively applies to the runtimes at
v1.1.0-rc2
. All posterior changes need to be ported and re-applied here.Changes:
glutton
togluttons
The changes can be reproduce with this script (it requires two user-interactions):
git clone https://github.com/ggwpez/substrate-scripts/ --depth 1 --branch master cd substrate-scripts/import-runtime-repos/ ./runtime-import.sh
The path mappings for manually importing code can be taken from this scripts.