-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Polkadot Coretime runtime #410
Merged
fellowship-merge-bot
merged 32 commits into
polkadot-fellows:main
from
seadanda:donal-coretime-polkadot
Aug 13, 2024
Merged
Add the Polkadot Coretime runtime #410
fellowship-merge-bot
merged 32 commits into
polkadot-fellows:main
from
seadanda:donal-coretime-polkadot
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
eskimor
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Don't we launch with async backing?
Also don't we need to apply these changes to allow unpaid execution from the coretime chain? |
bkchr
approved these changes
Aug 12, 2024
system-parachains/coretime/coretime-polkadot/src/genesis_config_presets.rs
Show resolved
Hide resolved
Co-authored-by: Bastian Köcher <[email protected]>
bkontur
reviewed
Aug 13, 2024
/merge |
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit Aug 13, 2024
9d3d5f6
into
polkadot-fellows:main
47 checks passed
seadanda
added a commit
to seadanda/runtimes
that referenced
this pull request
Aug 14, 2024
…chains (#4) * Add kusama live preset and chain spec to builder * Add coretime-polkadot chainspec * Make clippy happy * Remove unnecessary dep * Use presets for new chainspecs * Add live to preset names * Add stake plus bootnodes to coretime polkadot at release. (#5) * Add the Polkadot Coretime runtime (polkadot-fellows#410) Add the Polkadot Coretime chain in advance of the 1.3.0 release. This uses the new Price adapter which has been running on Kusama now for two sales cycles, and includes the mechanism to burn revenue. TODO: - [x] Add Transact tests for hardcoded weights after polkadot-fellows#401 is merged - [ ] Rerun benchmarks and check hardcoded weights after merge The genesis chain-spec is developing on #4. This can be used as a merge target for any community boot nodes who would like to be included at genesis and will be separately merged to `main`. --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> * Update changelog * all runtimes: remove already applied migrations (polkadot-fellows#420) Remove migrations already **applied on-chain**. - [x] Does not require a CHANGELOG entry --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: joe petrowski <[email protected]> --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: joe petrowski <[email protected]>
fellowship-merge-bot bot
added a commit
that referenced
this pull request
Sep 6, 2024
This PR does three things related to chain-specs and genesis config presets: - Refactor `preset_names` to `genesis_config_presets` in all runtimes as suggested for the Polkadot Coretime runtime in #410. - Make the chain-spec generator use the preset from the WASM directly for each runtime. - Propagate the `on_chain_release_build` feature to the chain-spec generator. Without this we cannot generate live/genesis chain-specs with the chain-spec generator without having to post-process it to replace the WASM compiled with this flag. --------- Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Polkadot Coretime chain in advance of the 1.3.0 release.
This uses the new Price adapter which has been running on Kusama now for two sales cycles, and includes the mechanism to burn revenue.
TODO:
The genesis chain-spec is developing on seadanda#4. This can be used as a merge target for any community boot nodes who would like to be included at genesis and will be separately merged to
main
.Closes #403