Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Tooling Collective #474

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add the Tooling Collective #474

wants to merge 5 commits into from

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Oct 10, 2024

Adds the tooling collective with Candidate and Member ranks. There is only one Member track to keep things simple.
Seed list is inserted on runtime upgrade.

TODO:

  • Weights
  • Double check seed list
  • try-runtime check migration

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Copy link

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it very much!

@@ -44,6 +44,7 @@ mod weights;
pub mod xcm_config;
// Fellowship configurations.
pub mod fellowship;
pub mod potoc;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think it we really want potoc... Maybe tooling is a better idea.

Comment on lines +202 to +205
// 15 days to register for a salary payment.
type RegistrationPeriod = ConstU32<{ 15 * DAYS }>;
// 15 days to claim the salary payment.
type PayoutPeriod = ConstU32<{ 15 * DAYS }>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time is sensible to me 👍🏻

// 15 days to claim the salary payment.
type PayoutPeriod = ConstU32<{ 15 * DAYS }>;
// Total monthly salary budget.
type Budget = ConstU128<{ 250_000 * USDT_UNITS }>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this written anywhere in the proposal? Where does the number come from?

"15DCWHQknBjc5YPFoVj8Pn2KoqrqYywJJ95BYNYJ4Fj3NLqz",
"15DCZocYEM2ThYCAj22QE4QENRvUNVrDtoLBVbCm5x4EQncr",
"16a357f5Sxab3V2ne4emGQvqJaCLeYpTMx3TCjnQhmJQ71DX",
"13ogXJ1tpHZoaav2iQQRDH5eHcvpAEfwB1UFY6dijDBmDcic",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one, I guess, is @TarikGul. It'd be great that all accounts have an identity to ensure recognizability.

Comment on lines +286 to +298
"151S1YrZd4zfUYCeWhNERkGdmom8kdqAtRqtHwh9HYMTfFYJ",
"14DsLzVyTUTDMm2eP3czwPbH53KgqnQRp3CJJZS9GR7yxGDP",
"16JskuojL6mSp6HNcjiHYa9jqksWbLD8L9YGWU1ppiPWQ9sa",
"15oLanodWWweiZJSoDTEBtrX7oGfq6e8ct5y5E6fVRDPhUgj",
"14iKbZws1fjJ6TH27yoRq6KeeVNof83VmxUBN2W2udQVBe5o",
"12TNvHiRkwzYqT5UZ86cfUvBeZBjLLYUzHLa4Hix99oTrgqT",
"12W3ea6jWKhzSWSCMjUKqtDwasRACeYFGkyvVb9Y9b5dGm2v",
"15roJ4ZrgrZam5BQWJgiGHpgp7ShFQBRNLq6qUfiNqXDZjMK",
"15DCWHQknBjc5YPFoVj8Pn2KoqrqYywJJ95BYNYJ4Fj3NLqz",
"15DCZocYEM2ThYCAj22QE4QENRvUNVrDtoLBVbCm5x4EQncr",
"16a357f5Sxab3V2ne4emGQvqJaCLeYpTMx3TCjnQhmJQ71DX",
"13ogXJ1tpHZoaav2iQQRDH5eHcvpAEfwB1UFY6dijDBmDcic",
"16JGzEsi8gcySKjpmxHVrkLTHdFHodRepEz8n244gNZpr9J",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants