Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for crashing explorer #10967

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Patch for crashing explorer #10967

merged 1 commit into from
Sep 30, 2024

Conversation

piggydoughnut
Copy link
Contributor

@piggydoughnut piggydoughnut commented Sep 30, 2024 •
edited
Loading

Helps with #10954 but does not solve not parsing the AccountId

@piggydoughnut piggydoughnut mentioned this pull request Sep 30, 2024
Closed
Imod7
Imod7 approved these changes Sep 30, 2024
View reviewed changes
Copy link

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works. It loads the Laos apps page correctly and logs the error in the console.

TarikGul
TarikGul approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now, looks like it just needs AccountId20 as the type, but it will need a special case.

@TarikGul TarikGul merged commit 9b8fec7 into master Sep 30, 2024
6 of 7 checks passed
@TarikGul TarikGul deleted the dm-laos-network-connect-issue branch September 30, 2024 09:13
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@Imod7 Imod7 Imod7 approved these changes

@polkadot-js-bot polkadot-js-bot Awaiting requested review from polkadot-js-bot

Assignees
No one assigned
Labels
-auto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piggydoughnut @polkadot-js-bot @Imod7 @TarikGul