adressing review:

* improve naming * implement ParseOrNone for IParseable
polyadic · Sep 4, 2023 · c4d790f · c4d790f
1 parent 12f3c84
commit c4d790f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/Funcky/Extensions/ParseExtensions/ParseExtensions.GenericNumber.cs b/Funcky/Extensions/ParseExtensions/ParseExtensions.GenericNumber.cs
@@ -5,13 +5,13 @@
 namespace Funcky.Extensions;
 public static partial class ParseExtensions
 {
-    public static Option<TNumber> ParseGenericNumber<TNumber>(this string value, NumberStyles style, IFormatProvider? provider)
+    public static Option<TNumber> ParseNumberOrNone<TNumber>(this string value, NumberStyles style, IFormatProvider? provider)
         where TNumber : INumberBase<TNumber>
         => TNumber.TryParse(value, style, provider, out var result)
             ? result
             : Option<TNumber>.None;
 
-    public static Option<TNumber> ParseGenericNumber<TNumber>(this ReadOnlySpan<char> value, NumberStyles style, IFormatProvider? provider)
+    public static Option<TNumber> ParseNumberOrNone<TNumber>(this ReadOnlySpan<char> value, NumberStyles style, IFormatProvider? provider)
         where TNumber : INumberBase<TNumber>
         => TNumber.TryParse(value, style, provider, out var result)
             ? result

diff --git a/Funcky/Extensions/ParseExtensions/ParseExtensions.GenericParseable.cs b/Funcky/Extensions/ParseExtensions/ParseExtensions.GenericParseable.cs
@@ -3,10 +3,16 @@ namespace Funcky.Extensions;
 
 public static partial class ParseExtensions
 {
-    public static Option<TParseable> ParseGenericParsable<TParseable>(this ReadOnlySpan<char> value, IFormatProvider? provider)
+    public static Option<TParseable> ParseOrNone<TParseable>(this ReadOnlySpan<char> value, IFormatProvider? provider)
         where TParseable : ISpanParsable<TParseable>
         => TParseable.TryParse(value, provider, out var result)
             ? result
             : Option<TParseable>.None;
+
+    public static Option<TParseable> ParseOrNone<TParseable>(this string? value, IFormatProvider? provider)
+        where TParseable : IParsable<TParseable>
+        => TParseable.TryParse(value, provider, out var result)
+            ? result
+            : Option<TParseable>.None;
 }
 #endif
diff --git a/Funcky/PublicAPI.Unshipped.txt b/Funcky/PublicAPI.Unshipped.txt
@@ -10,6 +10,7 @@ Funcky.Monads.Result<TValidResult>.InspectError(System.Action<System.Exception!>
 Funcky.Monads.Result<TValidResult>.OrElse(Funcky.Monads.Result<TValidResult> fallback) -> Funcky.Monads.Result<TValidResult>
 Funcky.Monads.Result<TValidResult>.OrElse(System.Func<System.Exception!, Funcky.Monads.Result<TValidResult>>! fallback) -> Funcky.Monads.Result<TValidResult>
 static Funcky.Extensions.EnumeratorExtensions.MoveNextOrNone<T>(this System.Collections.Generic.IEnumerator<T>! enumerator) -> Funcky.Monads.Option<T>
-static Funcky.Extensions.ParseExtensions.ParseGenericNumber<TNumber>(this string! value, System.Globalization.NumberStyles style, System.IFormatProvider? provider) -> Funcky.Monads.Option<TNumber>
-static Funcky.Extensions.ParseExtensions.ParseGenericNumber<TNumber>(this System.ReadOnlySpan<char> value, System.Globalization.NumberStyles style, System.IFormatProvider? provider) -> Funcky.Monads.Option<TNumber>
-static Funcky.Extensions.ParseExtensions.ParseGenericParsable<TParseable>(this System.ReadOnlySpan<char> value, System.IFormatProvider? provider) -> Funcky.Monads.Option<TParseable>
+static Funcky.Extensions.ParseExtensions.ParseNumberOrNone<TNumber>(this string! value, System.Globalization.NumberStyles style, System.IFormatProvider? provider) -> Funcky.Monads.Option<TNumber>
+static Funcky.Extensions.ParseExtensions.ParseNumberOrNone<TNumber>(this System.ReadOnlySpan<char> value, System.Globalization.NumberStyles style, System.IFormatProvider? provider) -> Funcky.Monads.Option<TNumber>
+static Funcky.Extensions.ParseExtensions.ParseOrNone<TParseable>(this string? value, System.IFormatProvider? provider) -> Funcky.Monads.Option<TParseable>
+static Funcky.Extensions.ParseExtensions.ParseOrNone<TParseable>(this System.ReadOnlySpan<char> value, System.IFormatProvider? provider) -> Funcky.Monads.Option<TParseable>