New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user defined websocket URLs #20

Merged

justinpolygon merged 1 commit into polygon-io:master from matthiggins:feat/websocket-url-definition

Dec 11, 2023

Contributor

matthiggins commented Nov 29, 2023 •

edited

Loading

This PR allows for custom websocket urls in the WebsocketResource. This is a non-breaking change.

Define on instantiation : $socket = new WebsocketResource($topic, $apiKey, $socketUrl)
Define on instance : $socket->setSocketUrl($socketUrl)


          Allow websocket URL to be defined during instantiation in WebsocketRe…

dd9b57c

…source

Contributor

justinpolygon commented Dec 11, 2023

LGTM -- thanks for sending this in. At some point we'll probably refactor this to have a pre-defined set but this works for now.

justinpolygon merged commit 3024cde into polygon-io:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet