Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Diluted EPS(Earnings-Per-Share) #801

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Raptorly1
Copy link

Fixes #792

This pull request includes changes to the polygon/rest/models/financials.py file, primarily focusing on the addition of DilutedEarningsPerShare and the inclusion of this in the IncomeStatement class. Additionally, there are corresponding updates to the test file test_rest/test_financials.py.

New Class Addition:

  • Added a new class DilutedEarningsPerShare to represent diluted earnings per share data for an income statement. This class includes the standard attributes I saw: formula, label, order, unit, value, and xpath, along with a from_dict method.

Updates to Existing Classes:

  • Updated the IncomeStatement class to include an optional diluted_earnings_per_share attribute.
  • Modified the from_dict method of the IncomeStatement class to handle the new diluted_earnings_per_share attribute.

Test Updates:

  • Added DilutedEarningsPerShare to the import statements in the test_rest/test_financials.py file.
  • Updated the test_list_stock_financials method to test the new diluted_earnings_per_share attribute in the IncomeStatement class.

@Raptorly1 Raptorly1 changed the title Add Diluted EPS(Earnings-Per-Share Add Diluted EPS(Earnings-Per-Share) Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing diluted earnings-per-share from Financials.income_statement
1 participant