Add Diluted EPS(Earnings-Per-Share) #801
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #792
This pull request includes changes to the
polygon/rest/models/financials.py
file, primarily focusing on the addition ofDilutedEarningsPerShare
and the inclusion of this in theIncomeStatement
class. Additionally, there are corresponding updates to the test filetest_rest/test_financials.py
.New Class Addition:
DilutedEarningsPerShare
to represent diluted earnings per share data for an income statement. This class includes the standard attributes I saw:formula
,label
,order
,unit
,value
, andxpath
, along with afrom_dict
method.Updates to Existing Classes:
IncomeStatement
class to include an optionaldiluted_earnings_per_share
attribute.from_dict
method of theIncomeStatement
class to handle the newdiluted_earnings_per_share
attribute.Test Updates:
DilutedEarningsPerShare
to the import statements in thetest_rest/test_financials.py
file.test_list_stock_financials
method to test the newdiluted_earnings_per_share
attribute in theIncomeStatement
class.