Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(app-rust): improve rust app dev exp & ignore build folder #106

Merged
merged 2 commits into from
Oct 2, 2023
Merged

chore(app-rust): improve rust app dev exp & ignore build folder #106

merged 2 commits into from
Oct 2, 2023

Conversation

cbrzn
Copy link
Contributor

@cbrzn cbrzn commented Sep 7, 2023

this PR aims to improve the development experience with rust codegen:

  • removes the Module word from imported modules
  • update how the invoke overwrites are passed, now, an InvokeOptions struct has been created
  • imported env was missing, now its being correctly fetched

@cbrzn cbrzn requested a review from namesty as a code owner September 7, 2023 17:26
@cbrzn cbrzn changed the title chore: improve rust app dev exp & ignore build folder chore(app-rust): improve rust app dev exp & ignore build folder Sep 7, 2023
krisbitney
krisbitney suggested changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@krisbitney krisbitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really fantastic work. Thanks for doing this!!

implementations/app-rust/src/templates/types_rs.rs Outdated Show resolved Hide resolved
krisbitney
krisbitney approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@krisbitney krisbitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dOrgJelli dOrgJelli merged commit ab4d867 into main Oct 2, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@krisbitney krisbitney krisbitney approved these changes

@namesty namesty Awaiting requested review from namesty namesty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbrzn @dOrgJelli @krisbitney