Revert "Add links for term IDs in GO-CAM titles"

Temporarily revert to fix Angular errors with:
--configuration production

This reverts commit 519c5ea.

src/app/app.module.ts

@@ -323,7 +323,6 @@ export class PomBaseUrlSerializer extends DefaultUrlSerializer {
     ],
     bootstrap: [AppComponent],
     schemas: [CUSTOM_ELEMENTS_SCHEMA],
-    exports: [],
     imports: [
         IntersectionObserverModule.forRoot({
           debounce: 50,

src/app/go-cam-view-page/go-cam-view-page.component.html

@@ -1,14 +1,7 @@
 <div *ngIf="getIFrameURL()">
   <div class="header-section">
   <div class="return-to-gene-page">
-    <div class="title">GO-CAM pathway model
-      <span class="model-title-or-id">
-       <app-description-display *ngIf="gocamDetails && gocamDetails.title"
-         [description]="gocamDetails!.title"
-         [descriptionParts]="titleParts">
-       </app-description-display>
-       <span *ngIf="(!gocamDetails || !gocamDetails.title) && gocamId">{{gocamId}}</span>
-      </span>
+    <div class="title">GO-CAM pathway model <span class="model-title-or-id">{{getTitleOrId()}}</span>
       <span *ngIf="sourcePageType != 'docs'" class="go-cam-view">
         <span class="help-link"><a routerLink="/documentation/go-cam-pathway-models">All curated pathways</a></span>
       </span>

src/app/go-cam-view-page/go-cam-view-page.component.ts

@@ -4,7 +4,6 @@ import { ActivatedRoute, Params } from '@angular/router';
 import { DomSanitizer, Meta, SafeResourceUrl, Title } from '@angular/platform-browser';
 import { AppConfig, getAppConfig } from '../config';
 import { PombaseAPIService, GoCamDetails, GeneSummaryMap, GeneSummary } from '../pombase-api.service';
-import { TextOrTermId, Util } from '../shared/util';
 
 @Component({
     selector: 'app-go-cam-view-page',
@@ -24,7 +23,6 @@ export class GoCamViewPageComponent implements OnInit {
   sourceName?: string;
   modelGenes: Array<GeneSummary> = [];
   geneSummaryMap?: GeneSummaryMap;
-  titleParts: Array<TextOrTermId> = [];
 
   constructor(private titleService: Title,
               private sanitizer: DomSanitizer,
@@ -70,21 +68,14 @@ export class GoCamViewPageComponent implements OnInit {
     this.meta.updateTag({ property: 'description', content: title });
   }
 
-  setTitleParts(): void {
-    if (this.gocamDetails && this.gocamDetails.title) {
-      this.titleParts = Util.splitDescription(this.gocamDetails.title, this.gocamDetails.title_terms ?? []);
-    } else {
-      this.titleParts = [];
-    }
-  }
-
   ngOnInit(): void {
     this.route.params.forEach((params: Params) => {
       if (params['gocam_id'] !== undefined) {
         this.gocamId = params['gocam_id'];
 
         const summPromise = this.pombaseApi.getGeneSummaryMapPromise();
 
+
         const gocamDetailPromise = this.pombaseApi.getGoCamDetailById(this.gocamId!);
         gocamDetailPromise.then((details) => {
             this.gocamDetails = details;
@@ -97,8 +88,7 @@ export class GoCamViewPageComponent implements OnInit {
                  const geneSumm = geneSummMap[geneUniquename];
                  this.modelGenes.push(geneSumm);
               }
-              this.modelGenes.sort((a,b) => a.displayName().localeCompare(b.displayName()));
-              this.setTitleParts();
+              this.modelGenes.sort((a,b) => a.displayName().localeCompare(b.displayName()))
            })
 
         this.sourcePageType = params['source_page_type'];

src/app/pombase-api.service.ts

@@ -808,7 +808,6 @@ export interface GoCamContributor {
 export interface GoCamDetails {
   gocam_id: GoCamId;
   title?: string;
-  title_terms: Array<TermId>;
   genes: Array<GeneUniquename>;
   terms: Array<TermAndName>;
   contributors: Array<GoCamContributor>;

src/app/shared/gene-results/gene-results.component.html

@@ -5,9 +5,9 @@
   <div *ngIf="results">
     <div *ngIf="results.getRowCount() == 0" class="description">
       <span class="description-prefix">No results for:</span>
-      <app-description-display *ngIf="description || descriptionParts.length != 0"
+      <app-query-description-display *ngIf="description || descriptionParts.length != 0"
                                      [description]="description" [descriptionParts]="descriptionParts">
-      </app-description-display>
+      </app-query-description-display>
     </div>
 
     <app-genes-table *ngIf="results.getRowCount() != 0"

src/app/shared/gene-results/gene-results.component.ts

@@ -1,6 +1,5 @@
 import { Component, Input, OnInit, OnChanges } from '@angular/core';
 import { QueryResult, TermAndName } from '../../pombase-query';
-import { Util, TextOrTermId } from '../util';
 
 @Component({
     selector: 'app-gene-results',
@@ -14,7 +13,7 @@ export class GeneResultsComponent implements OnInit, OnChanges {
 
   description: string;
 
-  descriptionParts: Array<TextOrTermId> = [];
+  descriptionParts: Array<({ text?: string; term?: TermAndName; })> = [];
   termsInQuery: Array<TermAndName> = [];
 
   constructor() { }
@@ -31,9 +30,22 @@ export class GeneResultsComponent implements OnInit, OnChanges {
 
       this.termsInQuery = this.results.getQuery().referencedTerms();
       const termids = this.termsInQuery.map(term => term.termid);
+      const termidRe = new RegExp('(' + termids.join('|') + ')');
 
+      const descriptionBits = this.description.split(termidRe);
       this.descriptionParts =
-        Util.splitDescription(this.description, termids);
-    }
+        descriptionBits.map(bit => {
+          const index = termids.indexOf(bit);
+          if (index === -1) {
+            return {
+              text: bit,
+            };
+          } else {
+            return {
+              term: this.termsInQuery[index],
+            };
+          }
+        });
+      }
   }
 }

src/app/shared/genes-table/genes-table.component.html

@@ -8,9 +8,9 @@
     <span class="description-prefix" *ngIf="showingQuilt()">QuiLT visualisation of: </span>
     <span class="description-prefix" *ngIf="showingGeneEx()">Gene expression of: </span>
     <span class="description-prefix" *ngIf="!showingQuilt() && !showingGeneEx()">Query:</span>
-    <app-description-display *ngIf="description || descriptionParts.length != 0"
-                             [description]="description" [descriptionParts]="descriptionParts">
-    </app-description-display>
+    <app-query-description-display *ngIf="description || descriptionParts.length != 0"
+                                   [description]="description" [descriptionParts]="descriptionParts">
+    </app-query-description-display>
 
 
   <div *ngIf="showingQuilt()" class="documentation-link">

src/app/shared/genes-table/genes-table.component.ts

@@ -7,15 +7,15 @@ import { BsModalService, BsModalRef } from 'ngx-bootstrap/modal';
 import { PombaseAPIService, GeneSummaryMap, GeneShort } from '../../pombase-api.service';
 import { GenesDownloadDialogComponent } from '../../genes-download-dialog/genes-download-dialog.component';
 import { QueryService, HistoryEntry, DisplayResultRow } from '../../query.service';
-import { GeneQuery, GeneListNode, QueryResult } from '../../pombase-query';
+import { GeneQuery, GeneListNode, TermAndName, QueryResult } from '../../pombase-query';
 import { getAppConfig, GeneResultsFieldConfig } from '../../config';
 import { DeployConfigService } from '../../deploy-config.service';
 import { GenesTableConfigComponent } from '../../genes-table-config/genes-table-config.component';
 import { SettingsService } from '../../settings.service';
 import { Subscription } from 'rxjs';
 import { faCog } from '@fortawesome/free-solid-svg-icons';
 import { QueryRouterService } from '../../query-router.service';
-import { TextOrTermId, Util } from '../util';
+import { Util } from '../util';
 
 @Component({
     selector: 'app-genes-table',
@@ -30,7 +30,7 @@ export class GenesTableComponent implements OnInit {
   // a decomposed version of the description as an Array of Objects
   // like: [{text: "abnormal cell ... ("}, {term: <a TermShort>}, {text: ")"}, ...]
   // which allows the the termids in a description to be linked to the term pages
-  @Input() descriptionParts: Array<TextOrTermId> = [];
+  @Input() descriptionParts: Array<({ text?: string; term?: TermAndName; })> = [];
   @Input() genesOrResults: Array<GeneShort>|QueryResult;
 
   @ViewChild('interMineSendForm') interMineSendForm: ElementRef;

src/app/shared/query-description-display/query-description-display.component.html

@@ -0,0 +1,5 @@
+<span *ngIf="descriptionParts.length == 0">{{description}}</span>
+<span *ngIf="descriptionParts.length != 0">
+  <span *ngFor="let part of descriptionParts"><span *ngIf="part.text" [innerHTML]="part.text"></span><a *ngIf="part.term" routerLink="/term/{{part.term.termid}}">{{part.term.termid}}</a></span>
+</span>
+

src/app/shared/query-description-display/query-description-display.component.spec.ts

@@ -0,0 +1,25 @@
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+
+import { QueryDescriptionDisplayComponent } from './query-description-display.component';
+
+describe('QueryDescriptionDisplayComponent', () => {
+  let component: QueryDescriptionDisplayComponent;
+  let fixture: ComponentFixture<QueryDescriptionDisplayComponent>;
+
+  beforeEach(async(() => {
+    TestBed.configureTestingModule({
+      declarations: [ QueryDescriptionDisplayComponent ]
+    })
+    .compileComponents();
+  }));
+
+  beforeEach(() => {
+    fixture = TestBed.createComponent(QueryDescriptionDisplayComponent);
+    component = fixture.componentInstance;
+    fixture.detectChanges();
+  });
+
+  it('should create', () => {
+    expect(component).toBeTruthy();
+  });
+});

src/app/shared/query-description-display/query-description-display.component.ts

@@ -0,0 +1,23 @@
+import { Component, OnInit, Input } from '@angular/core';
+import { TermAndName } from '../../pombase-query';
+
+@Component({
+    selector: 'app-query-description-display',
+    templateUrl: './query-description-display.component.html',
+    styleUrls: ['./query-description-display.component.css'],
+    standalone: false
+})
+export class QueryDescriptionDisplayComponent implements OnInit {
+  @Input() description: string;
+
+  // a decomposed version of the description as an Array of Objects
+  // like: [{text: "abnormal cell ... ("}, {term: <a TermShort>}, {text: ")"}, ...]
+  // which allows the the termids in a description to be linked to the term pages
+  @Input() descriptionParts: Array<({ text?: string; term?: TermAndName; })> = [];
+
+  constructor() { }
+
+  ngOnInit() {
+  }
+
+}

src/app/shared/shared.module.ts

@@ -17,6 +17,7 @@ import { ExternalLinkComponent } from './external-link/external-link.component';
 import { GeneResultsComponent } from './gene-results/gene-results.component';
 import { GeneResultsVisComponent } from './gene-results-vis/gene-results-vis.component';
 import { GenesTableComponent } from './genes-table/genes-table.component';
+import { QueryDescriptionDisplayComponent } from './query-description-display/query-description-display.component';
 import { GeneLinkComponent } from './gene-link/gene-link.component';
 import { PageContentsMenuComponent } from './page-contents-menu/page-contents-menu.component';
 import { CvVersionComponent } from './cv-version/cv-version.component';
@@ -32,7 +33,6 @@ import { SocialContactComponent } from './social-contact/social-contact.componen
 import { GeneResultsSlimTableComponent } from './gene-results-slim-table/gene-results-slim-table.component';
 import { FacetedSearchComponent } from './faceted-search/faceted-search.component';
 import { ChromosomeOverviewComponent } from './chromosome-overview/chromosome-overview.component';
-import { DescriptionDisplayComponent } from './description-display/description-display.component';
 
 import { PublicationBadgeComponent } from './publication-badge/publication-badge.component';
 
@@ -74,7 +74,6 @@ import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';
     FacetedSearchComponent,
     ChromosomeOverviewComponent,
     PublicationBadgeComponent,
-    DescriptionDisplayComponent,
   ],
   declarations: [
     SlimTableComponent,
@@ -97,7 +96,7 @@ import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';
     GoCamTableComponent,
     SocialContactComponent,
     GeneResultsSlimTableComponent,
-    DescriptionDisplayComponent,
+    QueryDescriptionDisplayComponent,
     FacetedSearchComponent,
     ChromosomeOverviewComponent,
     PublicationBadgeComponent,

src/app/shared/util.ts

@@ -1,12 +1,7 @@
 import { SolrAlleleSummary } from '../complete.service';
 import { GenotypeDetails, GenotypeShort, GeneShort,
          AlleleShort, TranscriptDetails} from '../pombase-api.service';
-import { TermId } from '../pombase-query';
 
-export type TextOrTermId = {
-  text?: string;
-  termid?: TermId;
-}
 export class Util {
   static geneCompare(gene1: GeneShort, gene2: GeneShort): number {
     if (gene1.name) {
@@ -242,27 +237,4 @@ export class Util {
 
     return ret;
   }
-
-  static splitDescription(description: string, termids: Array<TermId>): Array<TextOrTermId> {
-    if (termids.length == 0) {
-      return [{ text: description }];
-    }
-
-    const termidRe = new RegExp('(' + termids.join('|') + ')');
-
-    const descriptionBits = description.split(termidRe);
-
-    return descriptionBits.map(bit => {
-      const index = termids.indexOf(bit);
-      if (index === -1) {
-        return {
-          text: bit,
-        };
-      } else {
-        return {
-          termid: bit,
-        };
-      }
-    });
-  }
 }