fix: now reasoning output is rendered in the UI #29
+286
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
force-pushed
the
nickytonline/reasoning-model-output
branch
from
079b6b1 to
42cb73b
Compare
nickytonline
changed the title
nickytonline
commented
May 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the chat API to support streaming reasoning output and adjusts UI components to render that output progressively.
- Enables streaming of reasoning output when the model starts with "o3"/"o4"
- Buffers reasoning summary updates and flushes them upon completion
- Replaces ReactMarkdown with a custom MarkdownContent component in chat-related UI components
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/api/chat.ts | Adds reasoning configuration to API request based on model prefix |
| src/lib/streaming.ts | Buffers and flushes reasoning summary text events in the stream |
| src/components/ReasoningMessage.tsx | Creates a dedicated component to render reasoning messages |
| src/components/MarkdownContent.tsx | Extracts markdown rendering into a reusable component |
| src/components/ChatMessage.tsx | Replaces direct ReactMarkdown usage with MarkdownContent |
| src/components/Chat.tsx | Incorporates streaming reasoning events into the chat UI |
nickytonline
force-pushed
the
nickytonline/reasoning-model-output
branch
2 times, most recently
from
1ff6422 to
d60c113
Compare
|
This is good to go. Do you still get crashes with this @wasaga? I was never able to replicate this with the reported crashes. Also, for
it's already set to |
nickytonline
force-pushed
the
nickytonline/reasoning-model-output
branch
from
d60c113 to
4c5b4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now reasoning output is rendered in the UI. Currently all the chunks for a reasoning summary get flushed at the same time. We can probably stream those in.
Closes #16
CleanShot.2025-05-29.at.22.21.51.mp4
Notes from @wasaga:
Note it already has
streaming: true.