Linux/Unix support, continued from PR #37 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get rid of platform_linux.{h,cpp}.
This seems to be defined in winsock2.h already.
This allows us to use the CLOCK_MONOTONIC flag. This option avoids issues should the system clock change while we are asking for the time in our program.
Instead we just copy them there for now.
|
I think it's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After two months of inactivity on #37 I took the liberty to apply most of the requested changes.
The big open question is the implementation of the
Pollfunctionality. Currently, the code still uses the POSIX implementation of the Win32 API. As a first version (and since the code is not being used in the vectorwar example) I think it's better to have this than nothing (or nothing that compiles).For the case that you want to implement a more POSIX-style API before merging this, I looked into how to implement such an API. I think using file descriptors for signaling of events could be the most appropriate way to handle these (if I understood this API correctly). Then we could use either
select(3P)(available on both MacOSX and Linux) orepoll(Linux) andkqueue(MacOSX, though I have read online that this function can be buggy) to check which event has fired (i. e. which file descriptor is readable).What do you think?