[RFC] Port the vectorwar example application to Linux using libSDL2, based on PR 52 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get rid of platform_linux.{h,cpp}.
This seems to be defined in winsock2.h already.
This allows us to use the CLOCK_MONOTONIC flag. This option avoids issues should the system clock change while we are asking for the time in our program.
Instead we just copy them there for now.
In theory this should make vectorwar run on every platform that libSDL2 supports. I have only tested Linux and Windows however.
|
Looks good. |
|
@Shugyousha any plan to rebase ? |
As far as I am aware neither PR52 nor the one that PR52 is based on (PR37) have been changed in the meantime. I don't think any rebasing should be necessary. |
|
Hey, since this repo seems to be basically abandonded, is anyone interested in just taking this branch and making it the main ggpo repo instead? |
|
I feel like someone should take lead on a multi platform ggpo fork.
Something with enough support that people can get behind and do incremental
fixes on.
…On Sat, Mar 20, 2021 at 8:34 PM ValorZardK ***@***.***> wrote:
Hey, since this repo seems to be basically abandonded, is anyone
interested in just taking this branch and making it the main ggpo repo
instead?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#57 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHU46CGYW3BXTDJI5QT6FLTEVSNBANCNFSM4NOVHANA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested that the vectorwar application compiles and runs both on Linux and Windows (10).
I am not too familiar with Windows development so I only managed to compile this by installing the SDL2 vcpkg package and adding a environment variable to CMake so it can find the library. The build process would have to be streamlined on Windows for sure (the vectorwar binaries are also created in different locations when built on Windows vs Linux. Not sure that is expected behaviour due to Visual Studio or not).
There are still quite a few bugs and unimplemented things (see below). If you are not opposed to porting vectorwar using libSDL2 I can continue to work on those.
font.h(mostly to avoid having to get CMake to copy a binary file to a place where it can be found on all platforms)Would you be willing to get the vectorwar application ported to more platforms using libSDL2? If so, I can invest more time into this and make a proper PR out of it.