Rejuvenate log levels (C/6000) #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiming-tang-cs
commented
Dec 2, 2019
| @@ -436,25 +436,25 @@ private EntityMention convertAceEntityMention(AceEntityMention entityMention, St | |||
| int extEnd = ext.getTokenEnd() - tokenOffset + 1; | |||
| if (extStart < 0) { | |||
| logger.severe("READER ERROR: Invalid extent start " + extStart + " for entity mention " + entityMention.getId() + " in document " + docId + " in sentence " + sentence); | |||
| logger.severe("This may happen due to incorrect EOS detection. Adjusting entity extent."); | |||
| logger.finest("This may happen due to incorrect EOS detection. Adjusting entity extent."); | |||
There was a problem hiding this comment.
Maybe incorrect should be in keyword set.
There was a problem hiding this comment.
Oh, actually, I think this one is good because this is about the error details rather than the error.
khatchad
reviewed
Dec 2, 2019
There was a problem hiding this comment.
I think this looks good but I am curious about https://cunyponder.slack.com/archives/D94JKN0G4/p1575325778114400?thread_ts=1575323727.111500&cid=D94JKN0G4.
|
Please post this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We appreciate your previous feedback and it's very helpful! Here's a reissue of stanfordnlp#872 with a new version of our tool. The tool made many fewer transformations. Again, we'd appreciate any feedback and are willing to make further changes if you wish to incorporate our PR into your project.
Settings
We have several analysis settings. We can vary these settings and rerun if you desire. The settings we are using in this pull request are:
Treat CONFIG levels as a category and not a traditional level, i.e., our tool ignores these log levels.
Never lower the logging level of logging statements within catch blocks.
Never lower the logging level of logging statements within if statements.
Never lower the logging level of logging statements containing certain (important) keywords.
Never raise the logging level of logging statements without particular keywords in their messages.
Avoid log wrapping by disregarding logging statements contained in if statements mentioning log levels.
The greatest number of commits from HEAD evaluated: 6000.
The head at the time of analysis was: d7356db