-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rejuvenate log levels (C/6000) #5
base: master_11_21_2019
Are you sure you want to change the base?
Conversation
@@ -436,25 +436,25 @@ private EntityMention convertAceEntityMention(AceEntityMention entityMention, St | |||
int extEnd = ext.getTokenEnd() - tokenOffset + 1; | |||
if (extStart < 0) { | |||
logger.severe("READER ERROR: Invalid extent start " + extStart + " for entity mention " + entityMention.getId() + " in document " + docId + " in sentence " + sentence); | |||
logger.severe("This may happen due to incorrect EOS detection. Adjusting entity extent."); | |||
logger.finest("This may happen due to incorrect EOS detection. Adjusting entity extent."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe incorrect
should be in keyword set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, actually, I think this one is good because this is about the error details rather than the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good but I am curious about https://cunyponder.slack.com/archives/D94JKN0G4/p1575325778114400?thread_ts=1575323727.111500&cid=D94JKN0G4.
Please post this one. |
We appreciate your previous feedback and it's very helpful! Here's a reissue of stanfordnlp#872 with a new version of our tool. The tool made many fewer transformations. Again, we'd appreciate any feedback and are willing to make further changes if you wish to incorporate our PR into your project.
Settings
We have several analysis settings. We can vary these settings and rerun if you desire. The settings we are using in this pull request are:
Treat CONFIG levels as a category and not a traditional level, i.e., our tool ignores these log levels.
Never lower the logging level of logging statements within catch blocks.
Never lower the logging level of logging statements within if statements.
Never lower the logging level of logging statements containing certain (important) keywords.
Never raise the logging level of logging statements without particular keywords in their messages.
Avoid log wrapping by disregarding logging statements contained in if statements mentioning log levels.
The greatest number of commits from HEAD evaluated: 6000.
The head at the time of analysis was: d7356db