Fiber refactorings #8

bgprudhomme · 2024-07-02T00:47:29Z

No description provided.

bgprudhomme · 2024-07-02T01:27:03Z

src/edu/stanford/nlp/naturalli/OpenIE.java

@@ -691,7 +691,7 @@ public static void main(String[] args) throws IOException, InterruptedException
    }});
    ArgumentParser.fillOptions(new Class[]{OpenIE.class, ArgumentParser.class}, props);
    AtomicInteger exceptionCount = new AtomicInteger(0);
-    ExecutorService exec = Executors.newFixedThreadPool(ArgumentParser.threads);
+    ExecutorService exec = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:27:32Z

src/edu/stanford/nlp/patterns/GetPatternsFromDataMultiClass.java

@@ -956,7 +956,7 @@ public static Counter<CandidatePhrase> runLabelSeedWords(Map<String, DataInstanc

    Redwood.log(Redwood.DBG,"ignoreCaseSeedMatch is " + constVars.ignoreCaseSeedMatch);
    List<List<String>> threadedSentIds = getThreadBatches(new ArrayList<>(sents.keySet()), constVars.numThreads);
-    ExecutorService executor = Executors.newFixedThreadPool(constVars.numThreads);
+    ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:27:37Z

src/edu/stanford/nlp/patterns/GetPatternsFromDataMultiClass.java

@@ -1636,7 +1636,7 @@ private void calculateSufficientStats(Map<String, DataInstance> sents,
    List<List<String>> sampledSentIds = splitIntoNumThreadsWithSampling(CollectionUtils.toList(sents.keySet()), sampleSize, constVars.numThreads);
    Redwood.log(Redwood.DBG,"sampled " + sampleSize + " sentences (" + constVars.sampleSentencesForSufficientStats*100 + "%)");

-    ExecutorService executor = Executors.newFixedThreadPool(constVars.numThreads);
+    ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:28:07Z

src/edu/stanford/nlp/patterns/ScorePhrases.java

@@ -232,7 +232,7 @@ private void runParallelApplyPats(Map<String, DataInstance> sents, String label,
    else
      num = sents.size() / (numThreads - 1);

-    ExecutorService executor = Executors.newFixedThreadPool(constVars.numThreads);
+    ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:28:25Z

src/edu/stanford/nlp/patterns/ScorePhrasesLearnFeatWt.java

@@ -455,7 +455,7 @@ Set<CandidatePhrase> chooseUnknownAsNegatives(Set<CandidatePhrase> candidatePhra

    AtomicDouble allMaxSim = new AtomicDouble(Double.MIN_VALUE);

-    ExecutorService executor = Executors.newFixedThreadPool(constVars.numThreads);
+    ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:28:29Z

src/edu/stanford/nlp/patterns/ScorePhrasesLearnFeatWt.java

@@ -905,7 +905,7 @@ public GeneralDataset<String, ScorePhraseMeasures> choosedatums(boolean forLearn
        Data.computeRawFreqIfNull(sents, PatternFactory.numWordsCompoundMax);

      List<List<String>> threadedSentIds = GetPatternsFromDataMultiClass.getThreadBatches(new ArrayList<>(sents.keySet()), constVars.numThreads);
-      ExecutorService executor = Executors.newFixedThreadPool(constVars.numThreads);
+      ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:28:46Z

src/edu/stanford/nlp/pipeline/StanfordCoreNLPServer.java

-    this.serverExecutor = Executors.newFixedThreadPool(ArgumentParser.threads);
-    this.corenlpExecutor = Executors.newFixedThreadPool(ArgumentParser.threads);
+    this.serverExecutor = Executors.newVirtualThreadPerTaskExecutor();
+    this.corenlpExecutor = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:28:56Z

src/edu/stanford/nlp/trees/international/spanish/SpanishXMLTreeReader.java

@@ -498,7 +498,7 @@ public static void main(String[] args) {

    final SpanishXMLTreeReaderFactory trf = new SpanishXMLTreeReaderFactory(true, true, ner, detailedAnnotations, expandElisions, expandConmigo);
    ExecutorService pool =
-      Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors());
+      Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:29:40Z

src/edu/stanford/nlp/util/concurrent/MulticoreWrapper.java

-    // Default should be false
-    threadPool.allowCoreThreadTimeOut(false);
-    threadPool.prestartAllCoreThreads();
-


These are functions of ThreadPoolExecutor, not ExecutorService

bgprudhomme · 2024-07-02T01:29:53Z

src/edu/stanford/nlp/util/concurrent/MulticoreWrapper.java

-        threadPool.getQueue().size(),
-        outputQueue.size(),
-        idleProcessors.size());
+    return "";


Ditto the above

bgprudhomme · 2024-07-02T01:30:11Z

src/edu/stanford/nlp/util/concurrent/SynchronizedInterner.java

@@ -128,7 +128,7 @@ public int size() {
  public static void main(final String[] args) throws InterruptedException {
    final Thread[] threads = new Thread[100];
    for (int i = 0; i < threads.length; i++) {
-      threads[i] = new Thread(() -> {
+      threads[i] = Thread.ofVirtual().unstarted(() -> {


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:30:43Z

src/edu/stanford/nlp/util/logging/Redwood.java

@@ -1136,7 +1136,7 @@ public static void threadAndRun(String title, Iterable<Runnable> runnables, int
        return;
      }
      //(create executor)
-      ExecutorService exec = Executors.newFixedThreadPool(numThreads);
+      ExecutorService exec = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

bgprudhomme · 2024-07-02T01:30:55Z

src/edu/stanford/nlp/util/logging/Redwood.java

@@ -1462,7 +1462,7 @@ public static void main(String[] args){
    Redwood.getHandler(ConsoleHandler.class).minLineCountForTrackNameReminder = 50;

    //--Multithreading
-    ExecutorService exec = Executors.newFixedThreadPool(10);
+    ExecutorService exec = Executors.newVirtualThreadPerTaskExecutor();


Not hit by tests run by mvn install

Fiber refactorings

29f06d3

bgprudhomme commented Jul 2, 2024

View reviewed changes

Merge branch 'java21_rethreader' into fibers_rethreader

ad91272

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fiber refactorings #8

Fiber refactorings #8

bgprudhomme commented Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

bgprudhomme Jul 2, 2024

Fiber refactorings #8

Are you sure you want to change the base?

Fiber refactorings #8

Conversation

bgprudhomme commented Jul 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment