Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Logger subclasses #203

Open
khatchad opened this issue May 1, 2019 · 1 comment
Open

Allow Logger subclasses #203

khatchad opened this issue May 1, 2019 · 1 comment
Assignees
@yiming-tang-cs
Labels
enhancement New feature or request
Milestone
Future

Comments

@khatchad
Copy link
Member

khatchad commented May 1, 2019

Why is it not okay to subclass Logger?

https://github.com/ponder-lab/Logging-Level-Evolution-Plugin/blob/35cab4012aec01d7f2d14a366141b4371fa16c4a/edu.cuny.hunter.log.core/src/edu/cuny/hunter/log/core/utils/Util.java#L112
@khatchad khatchad added the question Further information is requested label May 1, 2019
@khatchad
Copy link
Member Author

khatchad commented May 1, 2019

Same problem here: https://github.com/ponder-lab/Logging-Level-Evolution-Plugin/blob/35cab4012aec01d7f2d14a366141b4371fa16c4a/edu.cuny.hunter.log.core/src/edu/cuny/hunter/log/core/utils/Util.java#L171

@ponder-lab ponder-lab deleted a comment from yiming-tang-cs May 1, 2019
@khatchad khatchad added enhancement New feature or request and removed question Further information is requested labels May 1, 2019
@khatchad khatchad added this to the Future milestone May 1, 2019
@khatchad khatchad changed the title Why is it not okay to derive Logger? Allow Logger subclasses May 1, 2019
@yiming-tang-cs yiming-tang-cs mentioned this issue May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiming-tang-cs yiming-tang-cs

Labels
enhancement New feature or request
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@khatchad @yiming-tang-cs