-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fiber refactorings #4
base: java21_rethreader
Are you sure you want to change the base?
Conversation
@@ -432,6 +432,8 @@ public void testFutureBash() { | |||
+ 50 // for the listeners | |||
+ 50 // for the blocking get threads, | |||
+ 1); // for the main thread | |||
// Refactoring this causes AbstractFutureFallbackAtomicHelperTest to hang forever | |||
// (https://github.com/ponder-lab/guava/actions/runs/9654663319/job/26629281352#step:6:1102) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring this causes AbstractFutureFallbackAtomicHelperTest to hang forever
@@ -617,6 +619,8 @@ public void testSetFutureCancelBash() { | |||
+ size // for the listeners | |||
+ size // for the get threads, | |||
+ 1); // for the main thread | |||
// Refactoring this causes AbstractFutureFallbackAtomicHelperTest to hang forever | |||
// (https://github.com/ponder-lab/guava/actions/runs/9654663319/job/26629281352#step:6:1102) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto the above
@@ -750,6 +754,8 @@ public void testSetFutureCancelBash_withDoneFuture() { | |||
2 // for the setter threads | |||
+ 1 // for the blocking get thread, | |||
+ 1); // for the main thread | |||
// Refactoring this causes AbstractFutureFallbackAtomicHelperTest to hang forever | |||
// (https://github.com/ponder-lab/guava/actions/runs/9654663319/job/26629281352#step:6:1102) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto the above
@@ -372,7 +372,7 @@ public String pendingToString() { | |||
} | |||
|
|||
public void testCompletionFinishesWithDone() { | |||
ExecutorService executor = Executors.newFixedThreadPool(10); | |||
ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issues as version in android directory (see above comments)
|
||
|
||
// Refactoring this causes test to hang for a while and eventually give wrong result | ||
// https://github.com/ponder-lab/guava/actions/runs/9736322153/job/26866789783#step:6:328 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring this causes test to hang for a while and eventually give wrong result
@@ -493,7 +493,7 @@ public void testRemovalNotification_clear_basher() throws InterruptedException { | |||
computationShouldWait.set(true); | |||
|
|||
final AtomicInteger computedCount = new AtomicInteger(); | |||
ExecutorService threadPool = Executors.newFixedThreadPool(nThreads); | |||
ExecutorService threadPool = Executors.newVirtualThreadPerTaskExecutor(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as version in android directory; see above comment
This reverts commit 432eed3.
No description provided.