Fiber refactorings #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgprudhomme
commented
Jul 1, 2024
| @@ -432,6 +432,8 @@ public void testFutureBash() { | |||
| + 50 // for the listeners | |||
| + 50 // for the blocking get threads, | |||
| + 1); // for the main thread | |||
| // Refactoring this causes AbstractFutureFallbackAtomicHelperTest to hang forever | |||
| // (https://github.com/ponder-lab/guava/actions/runs/9654663319/job/26629281352#step:6:1102) | |||
There was a problem hiding this comment.
Refactoring this causes AbstractFutureFallbackAtomicHelperTest to hang forever
bgprudhomme
commented
Jul 1, 2024
| @@ -617,6 +619,8 @@ public void testSetFutureCancelBash() { | |||
| + size // for the listeners | |||
| + size // for the get threads, | |||
| + 1); // for the main thread | |||
| // Refactoring this causes AbstractFutureFallbackAtomicHelperTest to hang forever | |||
| // (https://github.com/ponder-lab/guava/actions/runs/9654663319/job/26629281352#step:6:1102) | |||
bgprudhomme
commented
Jul 1, 2024
| @@ -750,6 +754,8 @@ public void testSetFutureCancelBash_withDoneFuture() { | |||
| 2 // for the setter threads | |||
| + 1 // for the blocking get thread, | |||
| + 1); // for the main thread | |||
| // Refactoring this causes AbstractFutureFallbackAtomicHelperTest to hang forever | |||
| // (https://github.com/ponder-lab/guava/actions/runs/9654663319/job/26629281352#step:6:1102) | |||
bgprudhomme
commented
Jul 1, 2024
| @@ -372,7 +372,7 @@ public String pendingToString() { | |||
| } | |||
|
|
|||
| public void testCompletionFinishesWithDone() { | |||
| ExecutorService executor = Executors.newFixedThreadPool(10); | |||
| ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor(); | |||
There was a problem hiding this comment.
Same issues as version in android directory (see above comments)
bgprudhomme
commented
Jul 1, 2024
|
|
||
|
|
||
| // Refactoring this causes test to hang for a while and eventually give wrong result | ||
| // https://github.com/ponder-lab/guava/actions/runs/9736322153/job/26866789783#step:6:328 |
There was a problem hiding this comment.
Refactoring this causes test to hang for a while and eventually give wrong result
bgprudhomme
commented
Jul 1, 2024
| @@ -493,7 +493,7 @@ public void testRemovalNotification_clear_basher() throws InterruptedException { | |||
| computationShouldWait.set(true); | |||
|
|
|||
| final AtomicInteger computedCount = new AtomicInteger(); | |||
| ExecutorService threadPool = Executors.newFixedThreadPool(nThreads); | |||
| ExecutorService threadPool = Executors.newVirtualThreadPerTaskExecutor(); | |||
There was a problem hiding this comment.
Same issue as version in android directory; see above comment
This reverts commit 432eed3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.