Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug triggered by OpenSSL 3.2.0 #107

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Fix bug triggered by OpenSSL 3.2.0 #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .release-notes/105.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Fix bug when using OpenSSL 3.2

OpenSSL 3.2 introduced a bug in itself or exposed one in NetSSL via a change in behavior. We believe the bug is in OpenSSL, either way, it was a problem.

HTTPS using the [Ponylang HTTP library](https://github.com/ponylang/http) get requests would hang when in release mode and segfault due to infinite recurion when in debug mode. We've introduced a fix and a regression test has been added to `ponylang/http`.
4 changes: 3 additions & 1 deletion net_ssl/ssl.pony
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ class SSL

if r <= 0 then
match @SSL_get_error(_ssl, r)
| 1 | 5 | 6 => _state = SSLError
| 1 | 5 | 6 =>
_state = SSLError
return None
| 2 =>
// SSL buffer has more data but it is not yet decoded (or something)
_read_buf.truncate(offset)
Expand Down
Loading