Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic "USB Flasher" name shown in application launcher instead of "Popsicle" #183

Open
cassidyjames opened this issue Jun 20, 2022 · 4 comments

Comments

@cassidyjames
Copy link
Contributor

It's strange to me that Popsicle is branded "Popsicle" on GitHub and Flathub, but the resulting app that's installed is called "USB Flasher," making it non-obvious to find the app after installation. I presume this was done so the app installed on Pop!_OS would be more obvious, but it means people who have sought it out on Flathub have a worse experience. I would recommend:

  • Renaming consistently to "Popsicle USB Flasher" on Flathub and the .desktop file for consistency, or
  • Carrying a patched .desktop on Pop!_OS to show the generic name instead so people who install from Flathub get the expected app name
techguy16 added a commit to techguy16/popsicle that referenced this issue Dec 10, 2022
pop-os#183 - Change "USB Flasher" to Popsicle
@techguy16
Copy link
Contributor

PR #198
Changes name to Popsicle

@jacobgkau
Copy link
Member

As brought up in #198 (comment), there is a GenericName field in the .desktop file specification for pretty much this reason. I don't think the Pop Shell launcher currently uses GenericName for anything, but the GNOME Applications menu uses GenericName for search matching (while displaying Name), and the KDE Kickoff launcher gives the option of displaying either one or both. Having Name set to Popsicle and GenericName set to USB Flasher seems semantically accurate.

Responding to @leviport's concern in #198 that people won't know what Popsicle is/does, the Pop Shell launcher does display Comment, so adding a comment as well would allow specifying that it's a USB flasher (KWrite uses both the GenericName and the Comment to indicate that it's a text editor, with the latter being a slightly longer phrase.)

@techguy16
Copy link
Contributor

Hi,
I have added your suggestions to the .desktop file

@cassidyjames
Copy link
Contributor Author

cassidyjames commented Dec 14, 2022

The way I have always described the FreeDesktop spec to developers (e.g. elementary AppCenter and GNOME app devs) is:

Name is a GenericName that lets you Comment.

So with Popsicle, it could be (while pulling from existing strings):

Name=Popsicle
GenericName=USB Flasher
Comment=Flash multiple USB devices in parallel

ids1024 pushed a commit that referenced this issue Aug 14, 2023
* Change name to Popsicle

#183 - Change "USB Flasher" to Popsicle

* Add suggestions

* Added a comment

Yes, I did it on my phone.

* Added suggestions

* fix: Use suggested & more natural wording

---------

Co-authored-by: Jacob Kauffmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants