Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposed assembly name in catalog docs #1655

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

andrewkern
Copy link
Member

this PR adds the assembly_name as a field of the Genome in the catalog docs. when rendered it looks like this:

image

this PR will close #1651 when merged

@andrewkern andrewkern requested a review from petrelharp January 17, 2025 15:11
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (abde1c4) to head (5230df4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1655   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         132      132           
  Lines        4584     4584           
  Branches      467      467           
=======================================
  Hits         4577     4577           
  Misses          3        3           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@petrelharp petrelharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@petrelharp petrelharp merged commit 6218f3d into popsim-consortium:main Jan 18, 2025
11 checks passed
@andrewkern andrewkern deleted the doc_assembly branch January 19, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add assembly name to the catalog
2 participants