Skip to content

Commit

Permalink
fix: provide port base url as default and correct test action (#5)
Browse files Browse the repository at this point in the history
Our integrations were broken because:
- A required parameter was added for the integration to work on the
backend, but wasn't set as required in the GitHub action inputs:
`pydantic.error_wrappers.ValidationError: 1 validation error for
IntegrationConfiguration
port -> base_url`

- The required parameter `https://app.getport.io` should be
`https://api.getport.io`

I left it as a default to `https://api.getport.io` which makes sense to
me but of course feel free to change. Adding an extra input for the API
URL seems like it's not needed for the user if it's the same for
everything.
  • Loading branch information
rorylogue authored Jun 10, 2024
1 parent 56f44a0 commit 05f813f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
type: 'jira'
port_client_id: ${{ secrets.PORT_CLIENT_ID }}
port_client_secret: ${{ secrets.PORT_CLIENT_SECRET }}
port_base_url: https://app.getport.io
config: |
jira_host: ${{ secrets.JIRA_HOST }}
atlassian_user_email: ${{ secrets.JIRA_USER_EMAIL }}
Expand Down
1 change: 1 addition & 0 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ inputs:
required: true
port_base_url:
description: 'The Port base URL'
default: 'https://api.getport.io'
required: false
initialize_port_resources:
description: 'Should Ocean try to create the default resources (blueprints, pages, integration config, etc.) provided with the integration'
Expand Down

0 comments on commit 05f813f

Please sign in to comment.