-
Notifications
You must be signed in to change notification settings - Fork 60
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Core] Extend ocean new cli command (#1255)
# Description fixed the flow of the ocean new command since it was not working properly by getting all data needed from the user and filling it out for him, and added debug file ## Type of change Please leave one option from the following and delete the rest: - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Documentation (added/updated documentation) <h4> All tests should be run against the port production environment(using a testing org). </h4> ### Core testing checklist - [ ] Integration able to create all default resources from scratch - [ ] Resync finishes successfully - [ ] Resync able to create entities - [ ] Resync able to update entities - [ ] Resync able to detect and delete entities - [ ] Scheduled resync able to abort existing resync and start a new one - [ ] Tested with at least 2 integrations from scratch - [ ] Tested with Kafka and Polling event listeners - [ ] Tested deletion of entities that don't pass the selector ### Integration testing checklist - [ ] Integration able to create all default resources from scratch - [ ] Resync able to create entities - [ ] Resync able to update entities - [ ] Resync able to detect and delete entities - [ ] Resync finishes successfully - [ ] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the `examples` folder in the integration directory. - [ ] If resource kind is updated, run the integration with the example data and check if the expected result is achieved - [ ] If new resource kind is added or updated, validate that live-events for that resource are working as expected - [ ] Docs PR link [here](#) ### Preflight checklist - [ ] Handled rate limiting - [ ] Handled pagination - [ ] Implemented the code in async - [ ] Support Multi account ## Screenshots Include screenshots from your environment showing how the resources of the integration will look. ## API Documentation Provide links to the API documentation used for this integration. --------- Co-authored-by: Matan <[email protected]>
- Loading branch information
Showing
8 changed files
with
51 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,18 +44,25 @@ $ [email protected] | |
release_date [2023-08-06]: | ||
$ 2023-08-06 | ||
|
||
is_private_integration [y/n] (y): | ||
$ n | ||
|
||
🌊 Ahoy, Captain! Your project is ready to set sail into the vast ocean of possibilities! | ||
Here are your next steps: | ||
port_client_id (you can find it using: https://docs.getport.io/build-your-software-catalog/custom-integration/api/#find-your-port-credentials): | ||
$ <your-port-client-id> | ||
|
||
port_client_secret (you can find it using: https://docs.getport.io/build-your-software-catalog/custom-integration/api/#find-your-port-credentials): | ||
$ <your-port-client-secret> | ||
|
||
⚓️ Install necessary packages: Run make install to install all required packages for your project. | ||
▶️ cd ./my_integration && make install && . .venv/bin/activate | ||
is_us_region [y/n] (n): | ||
$ y | ||
|
||
⚓️ Set sail with Ocean: Run ocean sail <path_to_integration> to run the project using Ocean. | ||
▶️ ocean sail ./my_integration | ||
🌊 Ahoy, Captain! Your project is ready to set sail into the vast ocean of possibilities! | ||
Here are your next steps: | ||
|
||
⚓️ Smooth sailing with Make: Alternatively, you can run make run to launch your project using Make. | ||
▶️ make run ./my_integration | ||
⚓️ Install necessary packages: Run cd ./my_integration && make install && . .venv/bin/activate to install all required packages for your project. | ||
⚓️ Copy example env file: Run cp .env.example .env and update your integration's configuration in the .env file. | ||
⚓️ Set sail with Ocean: Run ocean sail to run the project using Ocean. | ||
⚓️ Smooth sailing with Make: Alternatively, you can run make run ./my_integration to launch your project using Make. | ||
``` | ||
<br/> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,9 @@ | |
"email": "Your address email <[email protected]>", | ||
"release_date": "{% now 'local' %}", | ||
"is_private_integration": true, | ||
"port_client_id": "you can find it using: https://docs.getport.io/build-your-software-catalog/custom-integration/api/#find-your-port-credentials", | ||
"port_client_secret": "you can find it using: https://docs.getport.io/build-your-software-catalog/custom-integration/api/#find-your-port-credentials", | ||
"is_us_region": false, | ||
"_extensions": [ | ||
"jinja2_time.TimeExtension", | ||
"extensions.VersionExtension" | ||
|
8 changes: 6 additions & 2 deletions
8
port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.env.example
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,6 @@ | ||
OCEAN__PORT__CLIENT_ID="<port-client-id>" | ||
OCEAN__PORT__CLIENT_SECRET="<port-client-secret>" | ||
OCEAN__PORT__CLIENT_ID={{ cookiecutter.port_client_id }} | ||
OCEAN__PORT__CLIENT_SECRET={{ cookiecutter.port_client_secret }} | ||
OCEAN__INTEGRATION__IDENTIFIER={{ cookiecutter.integration_slug }} | ||
OCEAN__PORT__BASE_URL={% if cookiecutter.is_us_region %}https://api.us.getport.io{% else %}https://api.getport.io{% endif %} | ||
OCEAN__EVENT_LISTENER__TYPE=POLLING | ||
OCEAN__INITIALIZE_PORT_RESOURCES=true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
from port_ocean.cli.commands.main import cli_start | ||
|
||
|
||
if __name__ == "__main__": | ||
cli_start() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters