Skip to content

Commit

Permalink
[Integration][Fake Integration] Fix Black vulnerable to Regular Expre…
Browse files Browse the repository at this point in the history
…ssion Denial of Service (ReDoS) (#1137)
  • Loading branch information
Tankilevitch authored Nov 11, 2024
1 parent e6732bb commit 6aaaa28
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 32 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/verify-pr-title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
env:
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
if [[ ! "$PR_TITLE" =~ ^\[(Integration|Core|Docs|CI|Infra)\]\ .+ ]]; then
if [[ ! "$PR_TITLE" =~ ^\[(Integration|Core|Docs|CI|Infra)\](\[.*\])?\ .+ ]]; then
echo "PR title does not match the required convention."
echo "Examples of acceptable titles:"
echo "[Integration] Resolve missing team context in board ingestion for non-default teams"
Expand Down
8 changes: 8 additions & 0 deletions integrations/fake-integration/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

<!-- towncrier release notes start -->

## 0.1.15-dev (2024-11-11)


### Bug Fixes

- Resolve vulnerability "Black vulnerable to Regular Expression Denial of Service (ReDoS)" by bumping to ^24.4.2


## 0.1.14-dev (2024-11-10)


Expand Down
8 changes: 5 additions & 3 deletions integrations/fake-integration/fake_org_data/generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@ def generate_fake_persons(
email=fake.email(domain=company_domain),
age=randint(20, 100),
department=department,
status=FakePersonStatus.WORKING
if randint(0, 2) % 2 == 0
else FakePersonStatus.NOPE,
status=(
FakePersonStatus.WORKING
if randint(0, 2) % 2 == 0
else FakePersonStatus.NOPE
),
).dict()
)

Expand Down
54 changes: 27 additions & 27 deletions integrations/fake-integration/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integrations/fake-integration/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ faker = "^28.0.0"
[tool.poetry.group.dev.dependencies]
# Uncomment this if you want to debug the ocean core together with your integration
# port_ocean = { path = '../../', develop = true, extras = ['all'] }
black = "^23.3.0"
black = "^24.4.2"
mypy = "^1.3.0"
pre-commit = "^3.7.1"
pylint = "^2.17.4"
Expand Down

0 comments on commit 6aaaa28

Please sign in to comment.