Skip to content

Commit

Permalink
[Core] Fix apply-release.yml and bump-all.sh to look on different… (
Browse files Browse the repository at this point in the history
#1209)

# Description

What -
Ocean version is not parsed
Why -
Because `pip index versions` return LATEST tag only when the package is
already installed.
How -
changed the one liner to refer the start of the output to parse ocean
version
## Type of change

Please leave one option from the following and delete the rest:

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] New Integration (non-breaking change which adds a new integration)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Non-breaking change (fix of existing functionality that will not
change current behavior)
- [ ] Documentation (added/updated documentation)

<h4> All tests should be run against the port production
environment(using a testing org). </h4>

### Core testing checklist

- [ ] Integration able to create all default resources from scratch
- [ ] Resync finishes successfully
- [ ] Resync able to create entities
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Scheduled resync able to abort existing resync and start a new one
- [ ] Tested with at least 2 integrations from scratch
- [ ] Tested with Kafka and Polling event listeners
- [ ] Tested deletion of entities that don't pass the selector


### Integration testing checklist

- [ ] Integration able to create all default resources from scratch
- [ ] Resync able to create entities
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Resync finishes successfully
- [ ] If new resource kind is added or updated in the integration, add
example raw data, mapping and expected result to the `examples` folder
in the integration directory.
- [ ] If resource kind is updated, run the integration with the example
data and check if the expected result is achieved
- [ ] If new resource kind is added or updated, validate that
live-events for that resource are working as expected
- [ ] Docs PR link [here](#)

### Preflight checklist

- [ ] Handled rate limiting
- [ ] Handled pagination
- [ ] Implemented the code in async
- [ ] Support Multi account

## Screenshots

Include screenshots from your environment showing how the resources of
the integration will look.

## API Documentation

Provide links to the API documentation used for this integration.

Co-authored-by: Ivan Kalinovski <[email protected]>
  • Loading branch information
ivankalinovski and Ivan Kalinovski authored Dec 4, 2024
1 parent 14752f3 commit 8f3bd62
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/apply-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Get package version
id: version
run: |
version=$(pip index versions port-ocean | grep LATEST | cut -d':' -f2 | sed 's/ //g')
version=$(pip index versions port-ocean | grep 'port-ocean' | cut -d' ' -f2 | tr -d '()')
pr_name="[Integration] Apply Ocean version $version to all integrations"
branch_name="apply-ocean-$version-to-all-integrations"
echo "Branch Name: $branch_name"
Expand Down
2 changes: 1 addition & 1 deletion scripts/bump-all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
SCRIPT_BASE="$(cd -P "$(dirname "$0")" && pwd)"
ROOT_DIR="$(cd -P "${SCRIPT_BASE}/../" && pwd)"
CURRENT_DIR=$(pwd)
VERSION="^${1:-$(pip index versions port-ocean | grep LATEST | cut -d':' -f2 | sed 's/ //g')}"
VERSION="^${1:-$(pip index versions port-ocean | grep 'port-ocean' | cut -d' ' -f2 | tr -d '()')}"

echo "Going to bump ocean core to version ${VERSION} for all integrations"

Expand Down

0 comments on commit 8f3bd62

Please sign in to comment.