Skip to content

Commit

Permalink
[Framework] Safely get changelogDestination key instead of accessing …
Browse files Browse the repository at this point in the history
…it directly (#728)

# Description

What - changelogDestination key may not exist
How - solved by safely get changelogDestination key instead of accessing
it directly

## Type of change

Please leave one option from the following and delete the rest:

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] New Integration (non-breaking change which adds a new integration)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Non-breaking change (fix of existing functionality that will not
change current behavior)
- [ ] Documentation (added/updated documentation)

## Screenshots

Include screenshots from your environment showing how the resources of
the integration will look.

## API Documentation

Provide links to the API documentation used for this integration.
  • Loading branch information
omby8888 authored Jun 23, 2024
1 parent 15bb60e commit bf2b28a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

<!-- towncrier release notes start -->

## 0.9.1 (2024-06-23)


### Bug Fixes

- Safely get changelogDestination key instead of accessing it directly


## 0.9.0 (2024-06-19)


Expand Down
4 changes: 2 additions & 2 deletions port_ocean/core/defaults/initialize.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ async def _initialize_required_integration_settings(
"changelog_destination"
)
if (
integration["changelogDestination"] != changelog_destination
or integration["installationAppType"] != integration_config.integration.type
integration.get("changelogDestination") != changelog_destination
or integration.get("installationAppType") != integration_config.integration.type
or integration.get("version") != port_client.integration_version
):
await port_client.patch_integration(
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "port-ocean"
version = "0.9.0"
version = "0.9.1"
description = "Port Ocean is a CLI tool for managing your Port projects."
readme = "README.md"
homepage = "https://app.getport.io"
Expand Down

0 comments on commit bf2b28a

Please sign in to comment.