Skip to content

Commit

Permalink
PORT-7326-gitlab-0-1-58-bugfix-gitlab (#458)
Browse files Browse the repository at this point in the history
# Description

What - bugfix - could not run on startup when not configuring param
tokenGroupsHooksOverridMapping
Why - integration was failing to startup after merge
How - added check for not none on the param before using it

## Type of change

Please leave one option from the following and delete the rest:

- [ ] Bug fix (non-breaking change which fixes an issue)
  • Loading branch information
talru1123 authored Mar 24, 2024
1 parent 1f52c8d commit fa275ba
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
8 changes: 8 additions & 0 deletions integrations/gitlab/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

<!-- towncrier release notes start -->

0.1.59 (2024-03-24)
===================

### Bug Fixes

- Fix bug that could not run on startup when not configuring param tokenGroupsHooksOverridMapping (PORT-7326)


0.1.58 (2024-03-20)
===================

Expand Down
7 changes: 4 additions & 3 deletions integrations/gitlab/gitlab_integration/ocean.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ async def on_start() -> None:
hook_override_mapping: dict = integration_config[
"token_group_hooks_override_mapping"
]
sensitive_log_filter.hide_sensitive_strings(
*token_mapping.keys(), *hook_override_mapping.keys()
)
sensitive_log_filter.hide_sensitive_strings(*token_mapping.keys())

if hook_override_mapping is not None:
sensitive_log_filter.hide_sensitive_strings(*hook_override_mapping.keys())

if ocean.event_listener_type == "ONCE":
logger.info("Skipping webhook creation because the event listener is ONCE")
Expand Down
2 changes: 1 addition & 1 deletion integrations/gitlab/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "gitlab"
version = "0.1.58"
version = "0.1.59"
description = "Gitlab integration for Port using Port-Ocean Framework"
authors = ["Yair Siman-Tov <[email protected]>"]

Expand Down

0 comments on commit fa275ba

Please sign in to comment.