[Integration][Snyk] - Validation to Prevent Fetching Non Existent Users #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
approved these changes
Oct 24, 2024
- Includes tests for handling `None` user references, users from non-configured organizations, and cached user details. - Adds test coverage for successful user detail retrieval, 404 error handling, non-404 error handling, and empty API responses.
Co-authored-by: Tom Tankilevitch <[email protected]>
…g-org' of https://github.com/port-labs/ocean into PORT-10933-bug-snyk-ingesting-vulnerabilities-from-wrong-org
- Updated `mock_ocean_context` fixture to simplify initialization. - Converted `snyk_client` and `mock_event_context` fixtures to async generators.
…g-org' of https://github.com/port-labs/ocean into PORT-10933-bug-snyk-ingesting-vulnerabilities-from-wrong-org
- Simplified type annotations and variable declarations.
…end_api_request` directly.
- Update fixture and test method signatures. - Use `patch.object()` for more precise mocking. - Simplify async context management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Customers had the impression that the integration was bringing data from other organizations that were not specified during the installation process. The particular cause of concern was the Snyk API that enriches the project data with the importer and owner details. It is possible that an importer or the owner of the Snyk project have left the organization. In this instance, when we query the API, we will get 404, which is expected. But the fact that the customer sees an API call to the owners new organization makes it appear that the integration is pulling data from other org.
Why -
How - Added validation to prevent the integration from making attempts to fetch users from other organisation instead of the ones provided to the integration
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.