[Integration] [AWS] | Added support to choose specific regions to query resources from #1099
Conversation
Co-authored-by: Tom Tankilevitch <[email protected]>
integrations/aws/main.py
Outdated
| ) | ||
| return fastapi.Response(status_code=status.HTTP_200_OK) | ||
| else: | ||
| logger.exception("Failed to describe resource") |
There was a problem hiding this comment.
which resource? add log containing more context about the resource, region etc.
| @@ -46,16 +53,23 @@ def is_server_error(e: Exception) -> bool: | |||
|
|
|||
|
|
|||
| def get_matching_kinds_and_blueprints_from_config( | |||
There was a problem hiding this comment.
can we test it? with the new expected behavior?
…into improvement-aws
integrations/aws/utils/resources.py
Outdated
| logger.warning( | ||
| f"Skipping resyncing {kind} resource in region {region} in account {account_id}; {error.response['Error']['Message']}" | ||
| ) |
There was a problem hiding this comment.
how the error will look like? if we know that its resource not found, can't we provide more accurate log? I also think that its a info rather than a warning
There was a problem hiding this comment.
The error message has info about the identifier of the resource which can support debugging..
There was a problem hiding this comment.
Skipping resyncing AWS::EC2::Instance resource in region eu-north-1 in account 213138413742; Resource of type 'AWS::EC2::Instance' with identifier 'i-0dfe65a174b846790' was not found
Description
What:
regionPolicyin theselectorfield.maximumConcurrentAccount, to control the maximum number of concurrent accounts to sync.Why:
How:
selectorfield to support theregionPolicyfor querying resources from specific regions.maximumConcurrentAccountvariable, which limits the number of accounts synced concurrently.Type of change
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.