Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Bump to python version 3.12 #1103

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

erikzaadi
Copy link
Member

Description

What - Bump Python from 3.11 to 3.12

Why - Keep up to date with security vulnerabilities

Type of change

Please leave one option from the following and delete the rest:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@erikzaadi erikzaadi force-pushed the PORT-10418-official-bump-to-python-3.12 branch from 6f62a9e to 4e420e7 Compare October 27, 2024 09:21
@github-actions github-actions bot added size/XXL and removed size/M labels Oct 27, 2024
@erikzaadi erikzaadi force-pushed the PORT-10418-official-bump-to-python-3.12 branch 4 times, most recently from e8d20f0 to 5fe79b6 Compare November 2, 2024 15:56
@erikzaadi erikzaadi force-pushed the PORT-10418-official-bump-to-python-3.12 branch from 5fe79b6 to efd7e2b Compare November 7, 2024 08:24
@erikzaadi erikzaadi marked this pull request as ready for review November 7, 2024 08:24
@erikzaadi erikzaadi requested a review from a team as a code owner November 7, 2024 08:24
@erikzaadi erikzaadi changed the title Bump to python version 3.12 [CORE] Bump to python version 3.12 Nov 7, 2024
@erikzaadi erikzaadi force-pushed the PORT-10418-official-bump-to-python-3.12 branch 2 times, most recently from 6b3be77 to 40c1b00 Compare November 7, 2024 11:38
Copy link
Contributor

@shalev007 shalev007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think its worth to separate the bumping of python version of the integrations

@erikzaadi erikzaadi force-pushed the PORT-10418-official-bump-to-python-3.12 branch from 40c1b00 to 1506e58 Compare November 10, 2024 07:42
@github-actions github-actions bot added size/M and removed size/XXL labels Nov 10, 2024
@erikzaadi erikzaadi force-pushed the PORT-10418-official-bump-to-python-3.12 branch from 1506e58 to cf9b21f Compare November 10, 2024 07:54
@erikzaadi erikzaadi force-pushed the PORT-10418-official-bump-to-python-3.12 branch from cf9b21f to 71f483e Compare November 10, 2024 12:22
@erikzaadi erikzaadi merged commit 71f483e into main Nov 10, 2024
16 checks passed
@erikzaadi erikzaadi deleted the PORT-10418-official-bump-to-python-3.12 branch November 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants