-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][Gitlab] | Fix unintended deletion of file kinds #1104
Conversation
with logger.contextualize( | ||
files_path=selector.files.path, files_repos=selector.files.repos | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acknowledged
f"Processing project files for {projects_processed_in_full_batch}/{len(projects)} " | ||
f"projects in batch: {[project.path_with_namespace for project in projects_batch]}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be a bit too spammy 🤔 maybe change it to debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
What - Addresses unintended deletion of file-kind entities by enforcing the use of advanced search functionality for project file lookups.
Why - Entities created with a file-kind type get unexpectedly deleted due to inconsistent search results.
How - This fix introduces an explicit search_type parameter set to advanced within project.search, ensuring that all relevant files are accurately located during searches, thereby preventing inadvertent deletions during resource updates.
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.