-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][Terraform-Cloud] Add Rate Limiting Improvements #1110
Merged
Tankilevitch
merged 45 commits into
main
from
PORT-10857-adhere-to-terraform-cloud-api-rate-limits
Nov 26, 2024
Merged
[Integration][Terraform-Cloud] Add Rate Limiting Improvements #1110
Tankilevitch
merged 45 commits into
main
from
PORT-10857-adhere-to-terraform-cloud-api-rate-limits
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Tankilevitch
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing changelog
…https://github.com/port-labs/ocean into PORT-10857-adhere-to-terraform-cloud-api-rate-limits
…https://github.com/port-labs/ocean into PORT-10857-adhere-to-terraform-cloud-api-rate-limits
@@ -17,12 +22,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## 0.1.81 (2024-11-25) | |||
|
|||
|
|||
### Improvements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is removed?
Tankilevitch
approved these changes
Nov 26, 2024
PeyGis
approved these changes
Nov 26, 2024
Tankilevitch
deleted the
PORT-10857-adhere-to-terraform-cloud-api-rate-limits
branch
November 26, 2024 18:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What - This PR implements comprehensive rate limiting and concurrency control for the Terraform Cloud integration to prevent rate limit exhaustion and ensure reliable data synchronization.
Why - The integration was experiencing cascading failures during resyncs due to excessive API requests, leading to:
429 Too Many Requests
errorsHow - Implemented a multi-layered approach to rate limiting:
x-ratelimit-*
)client.py
: Rate limiting implementationAll tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
[Include screenshots of logs showing reduced 429 warnings, if available]
API Documentation