Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] auto-tag main on merge #1126

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shalev007
Copy link
Contributor

@shalev007 shalev007 commented Nov 6, 2024

Description

What - automate tagging main branch

Why - it's annoying to redo it manually each time

How - using github action

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@shalev007
Copy link
Contributor Author

Need to filter out only if pyproject.toml changed

@github-actions github-actions bot added size/S and removed size/XS labels Nov 7, 2024
@shalev007 shalev007 changed the title feat: auto-tag main on merge [CI/CD] auto-tag main on merge Nov 7, 2024
Copy link
Member

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some bash nits and 1 important git tag thingy

.github/workflows/tag-main.yml Outdated Show resolved Hide resolved
.github/workflows/tag-main.yml Outdated Show resolved Hide resolved
.github/workflows/tag-main.yml Outdated Show resolved Hide resolved
.github/workflows/tag-main.yml Outdated Show resolved Hide resolved
@shalev007 shalev007 force-pushed the PORT-11220-automate-git-tag-when-pushing-a-new-commit-to-main branch from 63df6a9 to 6f59d16 Compare November 26, 2024 21:27
@github-actions github-actions bot added size/L and removed size/S labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants