[Integration][ADO] Fix missing team context for non default teams while ingesting boards #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-Missing-Team-Context-for-Non-Default-Teams
PeyGis
requested changes
Nov 7, 2024
Comment on lines
+302
to
+303
| teams_url = f"{self._organization_base_url}/{API_URL_PREFIX}/projects/{project_id}/teams" | ||
| async for teams_in_project in self._get_paginated_by_top_and_skip(teams_url): |
There was a problem hiding this comment.
we have a generate_teams() method already. why don't you use that one?
There was a problem hiding this comment.
Generate teams gets the teams outside of the project context and it might not be suitable for this purpose
| teams_url = f"{self._organization_base_url}/{API_URL_PREFIX}/projects/{project_id}/teams" | ||
| async for teams_in_project in self._get_paginated_by_top_and_skip(teams_url): | ||
| for team in teams_in_project: | ||
| get_boards_url = f"{self._organization_base_url}/{project_id}/{team.get('id')}/{API_URL_PREFIX}/work/boards" |
There was a problem hiding this comment.
if the team ID is optional, thereby returning None, then let's catch it. If it's mandatory then lets do team["id"]
…on-Missing-Team-Context-for-Non-Default-Teams
Tankilevitch
changed the title
Tankilevitch
deleted the
PORT-11197-Bug-Azure-DevOps-Boards-Integration-Missing-Team-Context-for-Non-Default-Teams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What:
Updated the Azure DevOps Boards integration to include the team context by modifying the API call structure to iterate through all teams within a project.
Why:
Previously, the integration only retrieved boards at the project level using the
/{organization}/{project}/_apis/work/boardsendpoint. This approach limited data visibility to the default team's boards, resulting in missing boards and columns from non-default teams.How:
The integration was modified to use the
/{organization}/{project}/{team}/_apis/work/boardsendpoint, enabling iteration through all project teams. This change ensures that boards and columns from all teams within a project are included, improving overall data completeness and accuracy.Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.