[Core] Create webhooks only resync #1225
Open
+84
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
requested changes
Dec 12, 2024
Tankilevitch
requested changes
Dec 17, 2024
Comment on lines
+79
to
+82
| logger.debug( | ||
| "Webhook only event listener is used, resync events are ignored" | ||
| ) | ||
| return None |
| @@ -88,7 +92,11 @@ async def create_event_listener(self) -> BaseEventListener: | |||
| config, OnceEventListenerSettings | |||
| ), assert_message.format(type(config)) | |||
| event_listener = OnceEventListener(wrapped_events, config) | |||
|
|
|||
| case "webhooks_only": | |||
There was a problem hiding this comment.
can we manage those consts from one place?
Co-authored-by: Tom Tankilevitch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Added new event listener type- Webhooks only
Why - In order to enable 2 different integration types
How - Added new event listener without resync logic
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.