[Integration][Sentry] - Add Users and Teams #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
requested changes
Dec 18, 2024
Comment on lines
+31
to
+37
| "enum": [ | ||
| "member", | ||
| "admin", | ||
| "owner", | ||
| "manager", | ||
| "biling" | ||
| ], |
There was a problem hiding this comment.
is that something static by sentry or can be adjusted by each organization?
There was a problem hiding this comment.
this is static from the API and consistent with the Sentry UI
| ): | ||
| yield teams | ||
|
|
||
| @cache_iterator_result() |
There was a problem hiding this comment.
why you need to cache this?
| @@ -242,3 +242,36 @@ async def get_projects_tags_from_projects( | |||
| if project_tags_batch: | |||
| project_tags.append(project_tags_batch) | |||
| return flatten_list(project_tags) | |||
|
|
|||
| @cache_iterator_result() | |||
integrations/sentry/main.py
Outdated
Comment on lines
37
to
39
| async def fetch_team_members(team_slug: str) -> list[dict[str, Any]]: | ||
| return await sentry_client.get_team_members(team_slug) | ||
|
|
There was a problem hiding this comment.
why this isn't a client method? ideally we shouldn't declare a method inside another method
There was a problem hiding this comment.
Can you rephrase? I didn't understand the question
There was a problem hiding this comment.
feels redundant method I think
There was a problem hiding this comment.
it doesn't add anything specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Added sentry users and teams
Why - For improved data model
How - Added sentryUser and sentryTeam blueprint. And added a relation between issue and user
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Users
Teams
Team Members