Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration][ADO] Fix Entity Update Issue on Master Default Branch #1248

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

lordsarcastic
Copy link
Contributor

Description

What - Fixed a bug where push events aren't processed on default branches

Why - Push events are only processed on configured branches from port app config which makes things inflexible and causes bugs for other customers

How - Check for default branch in payload and run push events if current branch is default branch.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@lordsarcastic lordsarcastic requested a review from a team as a code owner December 17, 2024 16:13
Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added size/M and removed size/S labels Dec 19, 2024
@Tankilevitch Tankilevitch changed the title Bug | Entity Update Issue on Master Default Branch in ADO [Integration][ADO] Fix Entity Update Issue on Master Default Branch Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants