Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration][Kafka] Add consumer groups #1333

Merged
merged 15 commits into from
Jan 22, 2025
Merged

[Integration][Kafka] Add consumer groups #1333

merged 15 commits into from
Jan 22, 2025

Conversation

phalbert
Copy link
Contributor

@phalbert phalbert commented Jan 17, 2025 •
edited
Loading

Description

Add Kafka consumer groups

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@phalbert phalbert self-assigned this Jan 17, 2025
@phalbert phalbert requested a review from a team as a code owner January 17, 2025 14:35
@phalbert phalbert changed the title Add consumer groups [Integration][Kafka] Add consumer groups Jan 17, 2025
@github-actions github-actions bot added size/L and removed size/M labels Jan 17, 2025
mk-armah
mk-armah approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@mk-armah mk-armah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PeyGis
PeyGis requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go over my comment on the blueprint schema

integrations/kafka/.port/resources/blueprints.json Show resolved Hide resolved
integrations/kafka/.port/resources/blueprints.json Outdated Show resolved Hide resolved
integrations/kafka/.port/resources/blueprints.json Outdated Show resolved Hide resolved
@phalbert phalbert requested a review from PeyGis January 20, 2025 16:19
PeyGis
PeyGis approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phalbert
feat(kafka): revise seeding capability for integration testing
98a2512 
- Add seed_data.py script to create test topics and consumer groups
- Support multiple Kafka brokers for load testing
- Add generic seeding capability to _infra/Makefile
- Standardize seeding approach across integrations
@phalbert
Update seed_data.py
4cca898
Tankilevitch
Tankilevitch approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tankilevitch Tankilevitch merged commit f54b514 into main Jan 22, 2025
18 checks passed
@Tankilevitch Tankilevitch deleted the PORT-12483-add-support-for-consumer-groups-to-ports-kafka-integration branch January 22, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-armah mk-armah mk-armah approved these changes

@Tankilevitch Tankilevitch Tankilevitch approved these changes

@PeyGis PeyGis PeyGis approved these changes

Assignees

@phalbert phalbert

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phalbert @PeyGis @Tankilevitch @mk-armah