Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Core] Token refresh via error #1357

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

No0b1t0
Copy link
Contributor

@No0b1t0 No0b1t0 commented Jan 28, 2025

  • refresh token when invalid for pagerduty, support retry transport with custom method, async only, with tests
  • now support return to basic retry handeling when config file is not provided, with test

Description

What -
This PR holds within the scheduled refresh from the #1254 PR, this is a merge that also adds functionality for a custom retry invoked by the integration itself.
Why -
Instead of loading the configuration only on pod start, we aim to be able to periodically load the configuration and / or to load the details when we encounter an authentication error.
How -
This PR introduces an abstract class for Integration retry strategy and for refresh handling, while we aim to move the refresh
please note that the refresh from file was moved to the utils file at the core project, this way the integration will only ask to refresh the token without any consideration on how it is being implemented

tests were added as well

see additional details at task notion page: https://www.notion.so/Refresh-integration-configuration-from-file-part-A-1739be8ff7e380d5bcf7fd2442093f15?pvs=4

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

@github-actions github-actions bot added size/L and removed size/M labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants