Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resync-state kafka listener bug #931

Merged
merged 3 commits into from
Aug 21, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

<!-- towncrier release notes start -->

## 0.10.1 (2024-08-21)

### Improvements

- Fix kafka listener never ending resync loop due to resyncState updates

## 0.10.0 (2024-08-19)

### Improvements
Expand Down
10 changes: 7 additions & 3 deletions port_ocean/core/event_listener/kafka.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,13 @@ def _should_be_processed(self, msg_value: dict[Any, Any], topic: str) -> bool:
return False

integration_identifier = after.get("identifier")
if integration_identifier == self.integration_identifier and (
"change.log" in topic
):
if integration_identifier != self.integration_identifier:
return False

if after.get("updatedAt") == after.get("resyncState", {}).get("updatedAt"):
return False

if "change.log" in topic:
return msg_value.get("changelogDestination", {}).get("type", "") == "KAFKA"

return False
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "port-ocean"
version = "0.10.0"
version = "0.10.1"
description = "Port Ocean is a CLI tool for managing your Port projects."
readme = "README.md"
homepage = "https://app.getport.io"
Expand Down