Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 5363 UI for the kubernetes exporter moving the config into port #19

Conversation

yairsimantov20
Copy link
Contributor

Supported types for the EVENT_LISTENER__TYPE -> "KAFKA" / "POLLING" with default for Polling

Copy link
Contributor

@talsabagport talsabagport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Left some comments 🥇

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pkg/event_listener/consumer/consumer.go Outdated Show resolved Hide resolved
pkg/event_listener/event_listener_handler.go Outdated Show resolved Hide resolved
pkg/event_listener/event_listener_handler.go Outdated Show resolved Hide resolved
pkg/event_listener/event_listener_handler.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pkg/event_listener/polling/polling.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
"gopkg.in/yaml.v2"
"k8s.io/klog/v2"
"os"
"slices"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slices package doesn't exists in go 1.19, only starting from 1.21: https://pkg.go.dev/slices?tab=versions

main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pkg/event_handler/event_handler.go Outdated Show resolved Hide resolved
pkg/event_handler/polling/event_listener.go Outdated Show resolved Hide resolved
pkg/port/cli/integration.go Show resolved Hide resolved
pkg/port/cli/integration.go Show resolved Hide resolved
pkg/event_handler/consumer/event_listener.go Show resolved Hide resolved
pkg/event_handler/consumer/consumer_test.go Show resolved Hide resolved
pkg/event_handler/event_handler_test.go Show resolved Hide resolved
@yairsimantov20 yairsimantov20 merged commit b6c2412 into main Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants