fix page permissions (#166)

port-labs · Jul 25, 2024 · d0f5f03 · d0f5f03
1 parent 5f1f510
commit d0f5f03
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 4 deletions.
diff --git a/port/page-permissions/model.go b/port/page-permissions/model.go
@@ -9,7 +9,7 @@ type ReadPagePermissionsModel struct {
 }
 
 type PagePermissionsModel struct {
-	ID             types.String             `tfsdk:"id"`
-	PageIdentifier types.String             `tfsdk:"page_identifier"`
-	Read           ReadPagePermissionsModel `tfsdk:"read"`
+	ID             types.String              `tfsdk:"id"`
+	PageIdentifier types.String              `tfsdk:"page_identifier"`
+	Read           *ReadPagePermissionsModel `tfsdk:"read"`
 }
diff --git a/port/page-permissions/refreshPagePermissionsToState.go b/port/page-permissions/refreshPagePermissionsToState.go
@@ -8,7 +8,7 @@ import (
 func refreshPagePermissionsState(state *PagePermissionsModel, a *cli.PagePermissions, pageId string) error {
 	state.ID = types.StringValue(pageId)
 	state.PageIdentifier = types.StringValue(pageId)
-	state.Read = ReadPagePermissionsModel{}
+	state.Read = &ReadPagePermissionsModel{}
 
 	state.Read.Users = make([]types.String, len(a.Read.Users))
 	for i, u := range a.Read.Users {

diff --git a/port/page-permissions/resource_test.go b/port/page-permissions/resource_test.go
@@ -147,3 +147,40 @@ func TestAccPortPagePermissionsUpdateWithUsers(t *testing.T) {
 		},
 	})
 }
+
+func TestAccPortPagePermissionsImport(t *testing.T) {
+	pageIdentifier := utils.GenID()
+	err := os.Setenv("PORT_BETA_FEATURES_ENABLED", "true")
+	if err != nil {
+		t.Fatal(err)
+	}
+	var testAccPortPageResourceBasic = createPage(pageIdentifier)
+
+	var testAccBasePagePermissionsConfigUpdate = `
+
+	resource "port_page_permissions" "microservice_permissions" {
+		page_identifier = port_page.microservice_dashboard_page.identifier
+		read = {
+			"roles": [
+				"Member",
+			],
+			"users": [],
+			"teams": []
+			}
+	}`
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { acctest.TestAccPreCheck(t) },
+		ProtoV6ProviderFactories: acctest.TestAccProtoV6ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccPortPageResourceBasic + testAccBasePagePermissionsConfigUpdate,
+			},
+			{
+				ResourceName:      "port_page_permissions.microservice_permissions",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}