Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix webhook approval format and add tests #105

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix webhook approval format and add tests #105

merged 1 commit into from
Jan 17, 2024

Conversation

talsabagport
Copy link
Contributor

Description

What - fix webhook approval format and add tests. Fixes #101

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Tankilevitch
Tankilevitch approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talsabagport talsabagport merged commit 6e53f85 into main Jan 17, 2024
3 checks passed
@talsabagport talsabagport deleted the PORT-6149-tf-provider-encounters-an-error-when-configuring-webhook-approval-notification branch January 17, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tankilevitch Tankilevitch Tankilevitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TF Provider Error: mismatch between struct and object: Struct defines fields not found in object: format.
2 participants
@talsabagport @Tankilevitch