-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu screens #47
base: main
Are you sure you want to change the base?
Menu screens #47
Conversation
Add Slider Modify Button to have all 3 states
Refactored buttons, image, textbox Fix slider and button interactions
- Loading page (just increments by 1% each time the update function is called), need to switch to based on # of assets loaded - Added specification to all files
Updated Settings Added Assets for different menus
Separated research and game
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job on your first PR! I've left some general code comments that I expect to be applied on all files (e.g. multiple violations of using snake case for variables and function names in Python but I only commented in a specific area). most of these are stylistic changes I trust you to make but I'm requesting changes because I'd like to see on my end that changing scale
to smoothscale
throughout the codebase will make the assets clearer. please focus on this change while addressing my other comments!
…der + image name to [absolute path to folder][image name]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the quick changes. left some comments. in addition, please remove the .DS_Store
files from the PR and any other file changes that seem irrelevant to the PR (e.g. frontend/orders.py
, frontend/orders_set.py
, the fry_potato.json
change)
Overview
Implemented multiple menu screens and refactored the drawing system for better modularity. The menu system includes screens for the main menu, settings, end game, matchmaking, loading, logo display, and a pause menu. Refactored the simulator to be a class-based design. Enhanced the drawing process by introducing custom drawing classes and centralizing canvas ownership in the main.py file.
Changes Made
main.py
now has ownership of the game canvas. Game canvas ownership originally belonged torenderer.py
Test Coverage
Tested manually by navigating through all menu screens, interacting with UI elements, and ensuring seamless transitions. Verified that drawing components render correctly on the centralized canvas. Refactored simulator functionalities were tested by running sample simulations. Also tested all functionalities on different screen sizes.
Screenshots