Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Bug Key AKA Auto Key for OOK Editor app #2523

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Support Bug Key AKA Auto Key for OOK Editor app #2523

merged 4 commits into from
Feb 19, 2025

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Feb 17, 2025 •
edited
Loading

@gullradriel
Copy link
Member

Pretty good.

I have a few suggestion, that you may or not implement:

  • As we can set short step higher than long step, why not call these fields 'Step A' and 'Step B' or 'Primary Step' and 'Secondary Step' ?

  • Why not use '0' and '1' instead of '.' and '-' ?

gullradriel
gullradriel approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once you decide what to do with my remarks :-)
Nice work. I love it.

@zxkmm zxkmm marked this pull request as draft February 19, 2025 04:04
@zxkmm zxkmm marked this pull request as ready for review February 19, 2025 05:49
@zxkmm
Copy link
Contributor Author

zxkmm commented Feb 19, 2025

All suggestions accepted XD

@zxkmm zxkmm merged commit 5e55444 into portapack-mayhem:next Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel