Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated charts #992

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Deprecated charts #992

merged 1 commit into from
Feb 4, 2025

Conversation

nlamirault
Copy link
Collaborator

@nlamirault nlamirault commented Feb 4, 2025

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

  • Title of the PR starts with chart name (e.g. [portefaix-kyverno])
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • Chart Version bumped
  • ChangeLog.md has beed updated
  • Variables are documented in the README.md

Summary by CodeRabbit

  • Chores
    • Removed obsolete internal configuration files for Continuous Integration processes.

Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault added status/review_needed The issue or PR needs to be reviewed priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt area/helm Helm labels Feb 4, 2025
@nlamirault nlamirault self-assigned this Feb 4, 2025
Copy link

coderabbitai bot commented Feb 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request removes two Continuous Integration configuration files from the Linkerd mixin charts. Both deleted files provided test-related configurations such as additional labels and annotations along with Apache License details. No functional changes or modifications to publicly exported entities have been made; the update solely cleans up redundant CI configuration files.

Changes

File Path(s) Change Summary
charts/linkerd-{edge,stable}-mixin/ci/test-values.yaml Deleted CI configuration file containing test-specific metadata (labels "test": "github" and annotations "made-by": "portefaix") along with Apache License information.

Poem

I'm a bunny with a skip and a hop,
Celebrating clean code that just won't stop.
Goodbye old configs, out of sight,
My whiskers twitch in pure delight.
Hopping forward with each fresh change in flight!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 555789a and e56fb04.

📒 Files selected for processing (2)
  • charts/linkerd-edge-mixin/ci/test-values.yaml (0 hunks)
  • charts/linkerd-stable-mixin/ci/test-values.yaml (0 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the size/m Size M label Feb 4, 2025
@nlamirault nlamirault merged commit 446a722 into master Feb 4, 2025
16 of 24 checks passed
@nlamirault nlamirault deleted the feat/deprecated-charts branch February 4, 2025 17:28
@dosubot dosubot bot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix size/m Size M status/review_needed The issue or PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant