Add HTTP and HTTPS proxy to post-install-job #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tapas Sharma <[email protected]>
sharma-tapas
force-pushed
the
PB-1873
branch
from
cf181f5
to
2498e4b
Compare
adityadani
reviewed
Sep 14, 2021
| @@ -99,6 +99,9 @@ data: | |||
| batch | |||
| ## Sets the node identifier to the node name (= pod name). Node identifiers have to be unique. They can have a | |||
| ## maximum length of 23 characters. Thus, the chart's fullname template truncates its length accordingly. | |||
| {{- if or .Values.proxyHTTPEndpoint .Values.proxyHTTPSEndpoint }} | |||
| /subsystem=keycloak-server/spi=connectionsHttpClient/provider=default:write-attribute(name=properties.proxy-mappings,value=[".*{{ template "keykloak.proxy" . }}"]) | |||
There was a problem hiding this comment.
what if both http and https proxies are defined?
adityadani
approved these changes
Sep 14, 2021
|
Let's not push it with the chart version as 2.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tapas Sharma [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: