[OC-1082]: migration script to work even if px-backup is disabled and for external ls server. #320
+19
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for external ls server.
Changes to support 2.1.0 migration.
| current_px_central_version="2.0.0" | ||
| fi | ||
|
|
||
| # job_imagetag | ||
| if [ $current_px_central_version == "2.0.1" ]; then | ||
| # TODO: Needs to modify to public tags in 2.0.1 final patch | ||
| if [ $current_px_central_version == "2.1.0" ]; then |
There was a problem hiding this comment.
instead of using else if can we use an array or list of the version that is supported and check for that.
In long run this will keep adding to the complexity, a better solution would be to say we support all versions ahead of 2.0.0
| @@ -496,8 +500,8 @@ if [ "$helmvaluesfile" != "" ]; then | |||
| fi | |||
|
|
|||
| if [ "$px_central_version" != "" ]; then | |||
| if [ $px_central_version != "2.0.0" ] && [ $px_central_version != "2.0.1" ]; then | |||
| echo "upgrade-version can only be 2.0.1 or 2.0.0" | |||
| if [ $px_central_version != "2.1.0" ] && [ $px_central_version != "2.0.1" ] && [ $px_central_version != "2.0.0" ]; then | |||
There was a problem hiding this comment.
These supported versions should be in an array or a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signed-off-by: Diptiranjan
What this PR does / why we need it: