-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWX-37570 | Add missing fields for updateStrategy #597
Conversation
Signed-off-by: hitesh-wani-px <[email protected]>
2150690
to
775899d
Compare
Testing Notes:
|
@@ -115,3 +115,14 @@ clusterToken: | |||
|
|||
deleteStrategy: # Optional: Delete strategy for the portworx cluster | |||
type: # Valid values: Uninstall, UninstallAndWipe | |||
|
|||
updateStrategy: | |||
type: # portworx supports the following update strategies- RollingUpdate and OnDelete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add RollingUpdate as default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are only adding the updateStrategy in storageCluster if the user has specified valid values. The operator can handle the default values later if we not specifies any value in type.
PR looks good to me. |
Signed-off-by: hitesh-wani-px <[email protected]>
What this PR does / why we need it:
Added missing fields for updateStrategy component in storageCluster template
Which issue(s) this PR fixes (optional)
Closes #https://purestorage.atlassian.net/browse/PWX-37570
Special notes for your reviewer: