PB-4396 Added code to capture pod's description incase of failure #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OSS Scan Results:
Total issues: 0 |
|
License Evaluation Results:
Total License Issues: 19 |
shkumari-px
requested review from
siva-portworx,
prashanthpx,
lalat-das and
pallav-px
|
@shkumari-px The unit test result is not latest ? I see your name in that log.. Paste latest result of a failure scenario. |
|
Looks like you have closed the previous PR. Let's not do that. Rather we should always amend or add a new commit if review comments are fixed. If added a new commit to PR , make sure before pushing final PR squash them. Else ammend and force push the commit. That way exisiting comments will not wash away |
Hey yes, this is a new pr and the link to last one has been mentioned above, I'll attach the latest result for failed scenario |
|
OSS Scan Results:
Total issues: 0 |
|
License Evaluation Results:
Total License Issues: 19 |
lalat-das
approved these changes
Sep 27, 2023
| if err != nil { | ||
| logrus.Infof("Error fetching description of job-pod[%s] :%v", pod.Name, err) | ||
| } | ||
| logrus.Infof("start of job-pod[%s]'s description", pod.Name) |
There was a problem hiding this comment.
add some space between job-pod and pod name
| logrus.Infof("Error fetching description of job-pod[%s] :%v", pod.Name, err) | ||
| } | ||
| logrus.Infof("start of job-pod[%s]'s description", pod.Name) | ||
| logrus.Infof("Describe%v", podDescribe) |
There was a problem hiding this comment.
you dont need any word like Describe please delete it.
| @@ -507,7 +507,7 @@ func appendPodLogToStork(jobName string, namespace string) { | |||
| // Get job and check whether it has live pod attaced to it | |||
| job, err := batch.Instance().GetJob(jobName, namespace) | |||
| if err != nil && !k8sErrors.IsNotFound(err) { | |||
| logrus.Infof("failed in getting job %v/%v with err: %v", namespace, jobName, err) | |||
| logrus.Infof("failed in getting job %v/%v with err: %v and reason: %v", namespace, jobName, err, job.Status.Conditions[0].Reason) | |||
There was a problem hiding this comment.
Othertahn Notfound error is there a chnace the Job pointer will be returned with Nil value, In that case it can panic.. Please cross check .
|
OSS Scan Results:
Total issues: 0 |
|
License Evaluation Results:
Total License Issues: 19 |
Pb-4396 Added code to send Pod's describe output even if PodLog is being sent Pb-4396 Updated code to send Pod's describe output even if PodLog is being sent Pb-4396 Updated code to send Pod's describe output even if PodLog is being sent
shkumari-px
force-pushed
the
PB-4396-new
branch
from
00bf19a to
2f7f3a7
Compare
|
OSS Scan Results:
Total issues: 0 |
|
License Evaluation Results:
Total License Issues: 19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Capture job's and pod's describe output in case of failure.
Which issue(s) this PR fixes (optional)
Closes #309 https://portworx.atlassian.net/browse/PB-4396
Special notes for your reviewer:
Simulated a pod failure by giving wrong command to run inside the container which exits with non-zero status code
Checked the log for the leader stork pod while triggering a live backup